Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/19-mongolian #44

Closed
wants to merge 3 commits into from
Closed

Conversation

Nara1469
Copy link
Contributor

  • Replaced with the newer version text block in the Background section
  • Corrected some reviewed Mongolian translations

Nara1469 added 3 commits July 21, 2024 22:20
Added the translated texts at Background section
Fixed the translated text
Changed the renewed translation
Added some corrected mongolian translation
@ursjoss
Copy link
Collaborator

ursjoss commented Jul 26, 2024

Thanks for the additional commit with the updated GBD 2021 paragaraph and the general redcations, Nara.

As discussed, as this PR is not based on top of the main branch in the main repo and as it suffers from merge conflicts., I ported your latest commit into a new PR that is based on top of main. Closing this PR in favor of #45.

@ursjoss ursjoss closed this Jul 26, 2024
@ursjoss
Copy link
Collaborator

ursjoss commented Jul 26, 2024

Your changes have been deployed.

@Nara1469
Copy link
Contributor Author

Nara1469 commented Jul 26, 2024 via email

@ursjoss
Copy link
Collaborator

ursjoss commented Jul 26, 2024

Many thanks to you and the reviewers, Nara

@Nara1469
Copy link
Contributor Author

Nara1469 commented Aug 3, 2024 via email

@ursjoss
Copy link
Collaborator

ursjoss commented Aug 3, 2024

Dear Urs, Thanks for merging our latest update quickly. I'd like to apologize for creating a merge conflict with an outdated branch, I'll be aware of it for my next updates with new branches. As you know, Aza discussed earlier that we'd like to connect and show LUDOK interactive figure on our website (http://www.breathemongolia.org). I'd like to ask how we can show English and Mongolian versions using iframe on our website health page. I'd appreciate any advice. Thanks again. Best regards, Nara

See #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants