Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fitting of the emergence rate #281

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Improve fitting of the emergence rate #281

merged 3 commits into from
Nov 4, 2020

Conversation

acavelan
Copy link
Collaborator

@acavelan acavelan commented Nov 3, 2020

  • Greatly improve the fitting of the emergence rate, which causes the simulated EIR to be much closer to the input EIR
  • Change the Fourrier coefficients in some tests because the EIR profiles were too steep
  • Update the expected results of the tests

melissapenny
melissapenny approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@melissapenny melissapenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reviewed with Nakul and Aurelien

@acavelan acavelan merged commit 5cdd13e into develop Nov 4, 2020
@acavelan acavelan deleted the improveFitting branch January 6, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissapenny melissapenny melissapenny approved these changes

@nakul7 nakul7 Awaiting requested review from nakul7

@ThomasASmith ThomasASmith Awaiting requested review from ThomasASmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acavelan @melissapenny