Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove misleading optional arguments in .use #96

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

hugeblank
Copy link
Contributor

Removes "left"/"right" as valid names for the kinetic augment's .use method. Prevents the misleading situation where "right" refers to the main hand, which can be configured by the user to be the left hand (making the offhand the right hand).

fixes: #87

@Lemmmy Lemmmy merged commit cd8a1d4 into 1.20.1 Apr 3, 2024
@Lemmmy Lemmmy deleted the hugeblank/remove-misleading-use-args branch April 3, 2024 16:09
Lemmmy pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kinetic augment .use(duration, hand) does not respect left handedness
2 participants