Code Refactoring: Refactor telemetry to begin and end block #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-soon
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Remove hardcoded telemetry from modules * Add telemetry to begin/endblock * Remove test labels
yan-soon
added a commit
that referenced
this pull request
Nov 2, 2023
* Add liquidity provider fee pool * Add deliver tx and before commit hooks * Implements Valuer and Scanner interface for Int and Dec * Add after committer hook * Add liquidity provider fee pool to module account invariant * Add liquidity provider fee pool to distribution genesis check * Revert "Emit anthandler events even if txn fails or panics" This reverts commit c5adf7a. * Fix deliverTxer not including ante events on failed txns * Change authz module name from const to var * feat: increase DefaultGasLimit for cli tx * Add msg handler middleware * add: Hooks for send keeper * fix: Typos * fix: Type error * add error handling to hooks * add IsModuleAccount function in AccountKeeper to check if a supplied address is a module account. * add transfer hooks BeforeMultiSend and AfterMultiSend for multisend functionality * fix make install issue * remove unneeded hooks * Delete version specifally * Delete version * Panic on error * Add logs * Hardcode version delete * Force overwrite * Update iavl * Force delete version * Fix ver deletion * Rollback properly * Fix merge regressions * Fix rollback cmd * add evm mapping logic in accountKeeper and bankKeeper * edit getAccount to stay in line with initial cosmos sdk contract, ie return nil when address is nil instead of panic * revert HasAccount to its original definition in case future libraries/code uses it. set function which checks for account with mapping condition included name to be AccountExists instead * reverts commit b45c030 "revert HasAccount to its original definition in case future libraries/code uses it." * create GetMappedAccountAddressIfExists helper method in accountKeeper * refactor GetMappedAccountAddressIfExists to GetMergedAccountAddressIfExists and remove GetMappedAccountAddressIfExists in BaseSendKeeper * remove getting merged account logic in getAllBalances as it is already present in IterateAccountBalances * code clean up * move extraction of address from key to be in app logic rather than in accountKeeper * Revert "move extraction of address from key to be in app logic rather than in accountKeeper" This reverts commit e7af659. * add guard for iteration of EthAddressToCosmosAddress and CosmosAddressToEthAddressKey to prevent panic * update iavl * Code Refactoring: Refactor telemetry to begin and end block (#316) * Remove hardcoded telemetry from modules * Add telemetry to begin/endblock * Remove test labels * add GetMappedAddress helper method * ensure that event emitted from transfer of funds is from mapped address * Add telemetry to GRPC handler (#320) * feat/api node for off oracle service [WIP] (#333) * Add new address field to `app.toml` * Refactor typo * Refactor naming * Update oracle address port * add refund-handler to base-app * fix bug with refundHandler msCache * append refund events to anteEvents * feat: add before and after ModuleEndBlock * fix: db_backend lookup in config.toml see: cosmos#17181 * feat: telemetry monitor-store-size-interval config * fix conflicts from cherry-picking * add back legacy router to handle legacy sdk.msg routing * update proto related files * Revert "update proto related files" This reverts commit 8145796. * update distribution proto * add back value and scanner interface for LegacyDec * update cosmossdk.io/math pseudo ver * feat: add pruning-start-height flag to prune cmd * update distribution proto and rerun make proto-gen * update distribution proto and rerun make proto-gen again * change begin and end blockers for gov, staking and upgrade modules to accept ptr keeper instead * remove duplicate pruning cmd flag * use cosmos iavl instead of our fork * remove previous forked rollback code * update cometbft to v0.38.0 to fully utilise ABCI++ * Revert "update cometbft to v0.38.0 to fully utilise ABCI++" This reverts commit 57a9676. --------- Co-authored-by: Ivan Poon <ravenxce@gmail.com> Co-authored-by: Lee Yik Jiun <yikjiun.lee@switcheo.network> Co-authored-by: holyxiaoxin <jr.loves.maths@gmail.com> Co-authored-by: Ivan Poon <ivan.poon@switcheo.network> Co-authored-by: PC <spclight@gmail.com> Co-authored-by: Randy <randy75828@gmail.com> Co-authored-by: lance.lan <lmengsplist96@gmail.com> Co-authored-by: Nicholas Chung <84615041+chungnicholas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored hardcoded telemetry functions for begin and end blockers. It will be called dynamically within BeginBlock and EndBlock functions in types/module/module.go when module manager iterates through the begin/end blockers for all modules.