Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(cli): Unbox command should run as release (AztecProtocol#3974)
Running `aztec-cli unbox` with the 0.17.0 CLI will unbox creating an `.aztec-packages` folder and setting dependencies as portals: ``` ~/Projects/tmp/unbox$ which aztec-cli /home/santiago/.aztec/bin/aztec-cli ~/Projects/tmp/unbox$ aztec-cli --version 0.17.0 ~/Projects/tmp/unbox$ ls blank/.aztec-packages/ barretenberg yarn-project ~/Projects/tmp/unbox$ jq .dependencies blank/package.json { "@aztec/accounts": "portal:.aztec-packages/yarn-project/accounts", "@aztec/aztec.js": "portal:.aztec-packages/yarn-project/aztec.js", "serve": "^14.2.1" } ``` This seems to point to aztec-cli not picking up the `COMMIT_TAG` env var here: https://github.com/AztecProtocol/aztec-packages/blob/fc1d5399f24edafdc10cf9810f0cc6268008a3d8/yarn-project/cli/src/cmds/unbox.ts#L38-L55 This fix should make the env var available to the CLI. However, I haven't tested this (is it possible to build the cli image as if it were a release?), and it's unclear if this is the "right" fix. Should the CLI expect that env var at all? Should the default be "release mode" and only require an env var to run in "dev mode"?
- Loading branch information