Skip to content

Commit

Permalink
Remove ancient legacy stuff from Gemspec
Browse files Browse the repository at this point in the history
We seem to have a bunch of affordances in our `gemspec` for ancient
versions of rubygems.

A cursory look at this makes it clear that this wasn't actually maintained
(rspec specified 5 times, instead of the actual dependencies, for example),
and it's the year of our Lord 2021, we don't need this anymore.
  • Loading branch information
dmagliola committed May 13, 2021
1 parent 4ceee91 commit e6f28f8
Showing 1 changed file with 7 additions and 25 deletions.
32 changes: 7 additions & 25 deletions spreadsheetx.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -40,30 +40,12 @@ Gem::Specification.new do |s|
s.rubygems_version = '1.6.2'
s.summary = 'Facilitates opening and modifying existing xlsx excel spreadsheets'

if s.respond_to? :specification_version
s.specification_version = 3
s.specification_version = 3

if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0')
s.add_runtime_dependency('libxml-ruby', ['~> 3.1.0'])
s.add_runtime_dependency('zipruby', ['~> 0.3.6'])
s.add_development_dependency('bundler', ['~> 1.0.0'])
s.add_development_dependency('jeweler', ['~> 1.6.2'])
s.add_development_dependency('rcov', ['>= 0'])
s.add_development_dependency('rspec', ['~> 2.3.0'])
else
s.add_dependency('rspec', ['~> 2.3.0'])
s.add_dependency('rspec', ['~> 2.3.0'])
s.add_dependency('rspec', ['~> 2.3.0'])
s.add_dependency('rspec', ['~> 2.3.0'])
s.add_dependency('rspec', ['~> 2.3.0'])
s.add_dependency('zipruby', ['~> 0.3.6'])
end
else
s.add_dependency('bundler', ['~> 1.0.0'])
s.add_dependency('jeweler', ['~> 1.6.2'])
s.add_dependency('libxml-ruby', ['~> 3.1.0'])
s.add_dependency('rcov', ['>= 0'])
s.add_dependency('zipruby', ['~> 0.3.6'])
s.add_dependency('zipruby', ['~> 0.3.6'])
end
s.add_runtime_dependency('libxml-ruby', ['~> 3.1.0'])
s.add_runtime_dependency('zipruby', ['~> 0.3.6'])
s.add_development_dependency('bundler', ['~> 1.0.0'])
s.add_development_dependency('jeweler', ['~> 1.6.2'])
s.add_development_dependency('rcov', ['>= 0'])
s.add_development_dependency('rspec', ['~> 2.3.0'])
end

0 comments on commit e6f28f8

Please sign in to comment.