Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txt2img touch up + model switching #1139

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

protoplm
Copy link
Contributor

@protoplm protoplm commented Sep 15, 2022

Description

  • Swapped changes from Added custom models list to the txt2img tab. #1136 in txt2img to mirror img2img logic as the commit didn't properly function and referred to txt2vid models

  • Made state variables consistent with img2img.

  • Fixed a bug in sd_utils where switching models after running would not reload the used model.

  • Fixed update_preview_frequency and update_preview using defaults from webui_streamlit.yaml instead of state variables from UI.

TODO: Does sd_utils 174:177 need to run every time the model is switched or should it be overwritten using load_sd_model? The if/else as written takes a while to execute if changing models between runs.

config, device, model, modelCS, modelFS = load_sd_model(custom_model)

It takes a while if using the un-pruned waifu-diffusion regardless of deleting first or just overwriting. Should keep it as is.

Checklist:

  • [ - ] I have changed the base branch to dev
  • [ - ] I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

made state variables consistent with img2img.

Fixed a bug where switching models after running would not reload
the used model.
Copy link
Contributor

@Kasiya13 Kasiya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended

webui_streamlit.yaml instead of state variables from UI.
@protoplm protoplm marked this pull request as ready for review September 15, 2022 03:07
@ZeroCool940711 ZeroCool940711 merged commit f74d796 into Sygil-Dev:dev Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants