move payments constraint from xml to NewOrderType #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems to be a welcome change. However, since all constraints in Sylius are placed in xml files, I would go for changing the validation group name in |
|
@bartoszpietrzak1994 It was on purpose, I deleted the validation file that already existed in my PR to disable the validation globaly. |
|
Could this be merged? |
|
This validation should stay in xml file (according to current Sylius usage) and we may introduce a new validation group for this case (the similar thing is done for order complete) |
Prometee
pushed a commit
to Prometee/AdminOrderCreationPlugin
that referenced
this pull request
May 14, 2024
Use PhpSpec ^4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #77 (comment)
In some use cases, you don't need to validate payments outside of the plugin. (skip payment transition for example...etc)