Use the admin path name variable to allow the prefix value to be changed #196
Conversation
There was a problem hiding this comment.
Hi @delyriand, thank you for your contribution. 🙏
Since optimal solution is unavailable due BC promise and flex recipe, both Resources/config/app/routing.yml and Resources/config/app/ajax.yml files should be left where they are, but content can be changed.
So what do you say changing it like so,
# config/app/routing.yml
sylius_admin_order_creation:
resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin.yml"
prefix: "/%sylius_admin.path_name%"
sylius_admin_order_creation_ajax:
resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/ajax.yml"and
# config/app/ajax.yml
sylius_admin_order_creation_admin_ajax:
resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin/ajax.yml"
prefix: "/%sylius_admin.path_name%/ajax"Yeah, second sylius_admin_order_creation_admin_ajax declaration forces to add admin_ajax to make it unique, which is correct overall name, but doesn't match existing ajax route declaration, but shouldn't introduce any issues and acceptable compromise for me.
Keeping routes at config/app/routing instead of config/routing is acceptable since main file config/app/routing.yml already there and cannot be moved.
| @@ -52,7 +52,7 @@ sylius_admin_order_creation_ajax_product_variant_by_codes: | |||
| arguments: $code | |||
|
|
|||
| sylius_admin_order_creation_ajax_provide_available_shipping_methods: | |||
| path: /admin/orders/available-shipping-methods/{customerId}/{channelCode}/{shipmentNumber} | |||
| path: /orders/available-shipping-methods/{customerId}/{channelCode}/{shipmentNumber} | |||
There was a problem hiding this comment.
While this is correct change since route before this was /admin/ajax/admin/..., it's a sort of BC and should be avoided if possible.
There was a problem hiding this comment.
Renaming this file, which could have been imported directly before is a sort of BC.
| prefix: "/%sylius_admin.path_name%" | ||
| resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin.yml" |
There was a problem hiding this comment.
| prefix: "/%sylius_admin.path_name%" | |
| resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin.yml" | |
| resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin.yml" | |
| prefix: "/%sylius_admin.path_name%" |
| path: /admin/orders/new/select-customer | ||
| methods: [GET] | ||
| defaults: | ||
| _controller: Sylius\AdminOrderCreationPlugin\Controller\SelectNewOrderCustomerAction | ||
|
|
| prefix: "/ajax" | ||
| resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin_ajax.yml" |
There was a problem hiding this comment.
| prefix: "/ajax" | |
| resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin_ajax.yml" | |
| resource: "@SyliusAdminOrderCreationPlugin/Resources/config/app/routing/admin_ajax.yml" | |
| prefix: /ajax |
Ref #117
and see the comment in #118 (comment)