Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets reorganization #443

Merged
merged 3 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADE-2.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,3 +135,5 @@

Exceptions:
- Services required by Symfony to be `public` (e.g., controllers, event listeners) remain public.

1. `_javascript.html.twig` file has been removed, and its code has been moved to `src/Resources/assets/js/refund-button.js`. When upgrading to 2.0, import the `src/Resources/assets/entrypoint.js` file into your application’s main js file.
1 change: 1 addition & 0 deletions src/Resources/assets/entrypoint.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import './js/refund-button';
22 changes: 22 additions & 0 deletions src/Resources/assets/js/refund-button.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
$(document).ready(function() {
const $refundButtons = $('[data-refund]');
const $refundAllButton = $('[data-refund-all]');
const $refundClearAllButton = $('[data-refund-clear]');
const $refundInputs = $('[data-refund-input]');

$refundButtons.on('click', function(e) {
const $button = $(this);
const refundValue = $button.attr('data-refund');
const $refundInput = $button.closest('tr').find('[data-refund-input]');

$refundInput.val(refundValue);
});

$refundAllButton.on('click', function () {
$refundButtons.not(':disabled').trigger('click');
});

$refundClearAllButton.on('click', function () {
$refundInputs.val('');
});
});
24 changes: 0 additions & 24 deletions src/Resources/views/_javascripts.html.twig

This file was deleted.

2 changes: 0 additions & 2 deletions src/Resources/views/orderRefunds.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@

{% block javascripts %}
{{ parent() }}

{% include '@SyliusRefundPlugin/_javascripts.html.twig' %}
{% endblock %}
2 changes: 1 addition & 1 deletion tests/Application/assets/admin/entry.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
import 'sylius/bundle/AdminBundle/Resources/private/entry';
import '../../../../src/Resources/assets/entrypoint';
1 change: 0 additions & 1 deletion tests/Application/assets/shop/entry.js
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
import 'sylius/bundle/ShopBundle/Resources/private/entry';
16 changes: 12 additions & 4 deletions tests/Application/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,19 @@
"scripts": {
"build": "encore dev",
"build:prod": "encore production",
"postinstall": "semantic-ui-css-patch",
"lint": "yarn lint:js",
"watch": "encore dev --watch"
"watch": "encore dev --watch",
"postinstall": "cd ./node_modules/@symfony/ux-autocomplete && npm install && cd - && cd ./node_modules/@symfony/ux-live-component && npm install && cd -"
},
"dependencies": {
"@sylius-ui/admin": "git+https://github.com/Sylius/SyliusAdminBundle.git#2.0",
"@sylius-ui/shop": "git+https://github.com/Sylius/SyliusShopBundle.git#2.0",
"@symfony/ux-autocomplete": "file:../../vendor/symfony/ux-autocomplete/assets",
"@symfony/ux-live-component": "file:../../vendor/symfony/ux-live-component/assets"
},
"devDependencies": {
"@sylius-ui/frontend": "^1.0"
"@hotwired/stimulus": "^3.0.0",
"@symfony/stimulus-bridge": "^3.2.0",
"@symfony/webpack-encore": "^5.0.1",
"tom-select": "^2.2.2"
}
}
76 changes: 37 additions & 39 deletions tests/Application/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,49 +1,47 @@
const path = require('path');
const Encore = require('@symfony/webpack-encore');

const syliusBundles = path.resolve(__dirname, '../../vendor/sylius/sylius/src/Sylius/Bundle/');
const uiBundleScripts = path.resolve(syliusBundles, 'UiBundle/Resources/private/js/');
const uiBundleResources = path.resolve(syliusBundles, 'UiBundle/Resources/private/');
const SyliusAdmin = require('@sylius-ui/admin');
const SyliusShop = require('@sylius-ui/shop');

// Admin config
const adminConfig = SyliusAdmin.getWebpackConfig(path.resolve(__dirname));

// Shop config
const shopConfig = SyliusShop.getWebpackConfig(path.resolve(__dirname));

// App shop config
Encore
.setOutputPath('public/build/shop/')
.setPublicPath('/build/shop')
.addEntry('shop-entry', './assets/shop/entry.js')
.disableSingleRuntimeChunk()
.cleanupOutputBeforeBuild()
.enableSourceMaps(!Encore.isProduction())
.enableVersioning(Encore.isProduction())
.enableSassLoader();

const shopConfig = Encore.getWebpackConfig();

shopConfig.resolve.alias['sylius/ui'] = uiBundleScripts;
shopConfig.resolve.alias['sylius/ui-resources'] = uiBundleResources;
shopConfig.resolve.alias['sylius/bundle'] = syliusBundles;
shopConfig.resolve.alias['chart.js/dist/Chart.min'] = path.resolve(__dirname, 'node_modules/chart.js/dist/chart.min.js');
shopConfig.name = 'shop';
.setOutputPath('public/build/app/shop')
.setPublicPath('/build/app/shop')
.addEntry('app-shop-entry', './assets/shop/entry.js')
.disableSingleRuntimeChunk()
.cleanupOutputBeforeBuild()
.enableSourceMaps(!Encore.isProduction())
.enableVersioning(Encore.isProduction())
.enableSassLoader();

const appShopConfig = Encore.getWebpackConfig();

appShopConfig.externals = Object.assign({}, appShopConfig.externals, { window: 'window', document: 'document' });
appShopConfig.name = 'app.shop';

Encore.reset();

// Admin config
// App admin config
Encore
.setOutputPath('public/build/admin/')
.setPublicPath('/build/admin')
.addEntry('admin-entry', './assets/admin/entry.js')
.disableSingleRuntimeChunk()
.cleanupOutputBeforeBuild()
.enableSourceMaps(!Encore.isProduction())
.enableVersioning(Encore.isProduction())
.enableSassLoader();

const adminConfig = Encore.getWebpackConfig();

adminConfig.resolve.alias['sylius/ui'] = uiBundleScripts;
adminConfig.resolve.alias['sylius/ui-resources'] = uiBundleResources;
adminConfig.resolve.alias['sylius/bundle'] = syliusBundles;
adminConfig.resolve.alias['chart.js/dist/Chart.min'] = path.resolve(__dirname, 'node_modules/chart.js/dist/chart.min.js');
adminConfig.externals = { ...adminConfig.externals, window: 'window', document: 'document' };
adminConfig.name = 'admin';

module.exports = [shopConfig, adminConfig];
.setOutputPath('public/build/app/admin')
.setPublicPath('/build/app/admin')
.addEntry('app-admin-entry', './assets/admin/entry.js')
.disableSingleRuntimeChunk()
.cleanupOutputBeforeBuild()
.enableSourceMaps(!Encore.isProduction())
.enableVersioning(Encore.isProduction())
.enableSassLoader();

const appAdminConfig = Encore.getWebpackConfig();

appAdminConfig.externals = Object.assign({}, appAdminConfig.externals, { window: 'window', document: 'document' });
appAdminConfig.name = 'app.admin';

module.exports = [shopConfig, adminConfig, appShopConfig, appAdminConfig];
Loading