-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYL-4167: UI cleanup #457
SYL-4167: UI cleanup #457
Conversation
bartek-sek
commented
Dec 3, 2024
d954407
to
c79d94f
Compare
c79d94f
to
d6ccd67
Compare
...es/admin/order/refund/content/sections/form/items/table/body/products/refund_value.html.twig
Outdated
Show resolved
Hide resolved
|
||
'sylius_admin.order.show.content.sections.credit_memos.credit_memos.item.actions': | ||
'sylius_admin.order.show.content.sections.credit_memos.credit_memos.items.actions': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
credit_memos
part is duplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hook is used in partial that will be refactored in the next task, so I left it without changes.
<td class="text-center">{% include '@SyliusAdmin/shared/grid/field/channel.html.twig' with {'data': credit_memo.channel} %}</td> | ||
<td class="text-end"><strong>{{ money.format(credit_memo.total, credit_memo.currencyCode) }}</strong></td> | ||
<td class="w-1"> | ||
{% hook 'sylius_admin.order.show.content.sections.credit_memos.credit_memos.items.actions' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we triggering this hook here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the template that will be refactored in the next task, so I left it without changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but this hook has to be changed in the next iteration 🖖🏻
<div class="ui labeled input"> | ||
<div class="ui label">{{ order.currencyCode|sylius_currency_symbol }}</div> | ||
<div class="input-group"> | ||
<div class="input-group-text">{{ order.currencyCode|sylius_currency_symbol }}</div> | ||
{% set inputName = "sylius_refund_shipments["~shipping_adjustment.id~"][amount]" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use snake_case here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the template that will be refactored in the next task, so I left it without changes
e5cda4f
to
a364a51
Compare
{% set item = hookable_metadata.context.item %} | ||
|
||
<td> | ||
{{ '%0.2f'|format(item.netValue/100) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ '%0.2f'|format(item.netValue/100) }} | |
{{ (item.netValue / 100)|number_format(2) }} |