SYL-4167: UI cleanup #457
Merged
SYL-4167: UI cleanup #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bartek-sek
commented
Dec 3, 2024
bartek-sek
commented
mpysiak
force-pushed
the
SYL-4167/ui-cleanup
branch
from
d954407 to
c79d94f
Compare
mpysiak
force-pushed
the
SYL-4167/ui-cleanup
branch
from
c79d94f to
d6ccd67
Compare
GSadee
reviewed
Dec 5, 2024
...es/admin/order/refund/content/sections/form/items/table/body/products/refund_value.html.twig
Outdated
Show resolved
Hide resolved
GSadee
added
UX/UI
mpysiak
approved these changes
Dec 6, 2024
GSadee
reviewed
Dec 6, 2024
|
|
||
| 'sylius_admin.order.show.content.sections.credit_memos.credit_memos.item.actions': | ||
| 'sylius_admin.order.show.content.sections.credit_memos.credit_memos.items.actions': |
There was a problem hiding this comment.
This hook is used in partial that will be refactored in the next task, so I left it without changes.
| <td class="text-center">{% include '@SyliusAdmin/shared/grid/field/channel.html.twig' with {'data': credit_memo.channel} %}</td> | ||
| <td class="text-end"><strong>{{ money.format(credit_memo.total, credit_memo.currencyCode) }}</strong></td> | ||
| <td class="w-1"> | ||
| {% hook 'sylius_admin.order.show.content.sections.credit_memos.credit_memos.items.actions' %} |
There was a problem hiding this comment.
Why are we triggering this hook here? 🤔
There was a problem hiding this comment.
This is the template that will be refactored in the next task, so I left it without changes
There was a problem hiding this comment.
Ok, but this hook has to be changed in the next iteration 🖖🏻
| <div class="ui labeled input"> | ||
| <div class="ui label">{{ order.currencyCode|sylius_currency_symbol }}</div> | ||
| <div class="input-group"> | ||
| <div class="input-group-text">{{ order.currencyCode|sylius_currency_symbol }}</div> | ||
| {% set inputName = "sylius_refund_shipments["~shipping_adjustment.id~"][amount]" %} |
There was a problem hiding this comment.
This is the template that will be refactored in the next task, so I left it without changes
bartek-sek
force-pushed
the
SYL-4167/ui-cleanup
branch
from
e5cda4f to
a364a51
Compare
Wojdylak
approved these changes
Dec 6, 2024
| {% set item = hookable_metadata.context.item %} | ||
|
|
||
| <td> | ||
| {{ '%0.2f'|format(item.netValue/100) }} |
There was a problem hiding this comment.
Suggested change
| {{ '%0.2f'|format(item.netValue/100) }} | |
| {{ (item.netValue / 100)|number_format(2) }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.