Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Add more rules to the contribution guide + Fix CMS cookbook #9189

Merged
merged 3 commits into from
Feb 15, 2018

Conversation

CoderMaggie
Copy link
Member

Q A
Branch? 1.0
Doc fix? yes
New docs? yes
Related tickets fixes #9155 as it was missing inclusion in .rst file
License MIT

Added some statements regarding the neutrality of Sylius Documentation to the contribution guide.

@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 14, 2018
@@ -132,6 +132,10 @@ Language Standards
The Vitamins are in my Fresh California Raisins

* Do not use `Serial (Oxford) Commas`_;
* Please use appropriate, informative, rather formal language;
* Do not place any kind of advertisements in the documentation;
* The documentation should be neutral, without judgements, opnions. Make sure you do not favor anyone,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: opinions

@@ -132,6 +132,10 @@ Language Standards
The Vitamins are in my Fresh California Raisins

* Do not use `Serial (Oxford) Commas`_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that happen? :(

@pamil pamil added this to the 1.0 milestone Feb 14, 2018
Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased to target 1.0 branch.

@CoderMaggie CoderMaggie changed the base branch from master to 1.0 February 14, 2018 14:52
@pamil
Copy link
Contributor

pamil commented Feb 15, 2018

Thanks Magdalena Banasiak! 🥇

@bitbager
Copy link
Contributor

bitbager commented Feb 19, 2018

Thank you! 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants