-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doctrine/orm and fix deprecation #546
base: 1.11
Are you sure you want to change the base?
Conversation
@lchrusciel For new release, that's great, but to fix the 1.10 build, we need to fix Psalm error only. |
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
455784b
to
bb9ed26
Compare
@@ -69,7 +69,7 @@ public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs): void | |||
} | |||
} | |||
|
|||
public function postLoad(LifecycleEventArgs $args): void | |||
public function postLoad(PostLoadEventArgs $args): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function postLoad(PostLoadEventArgs $args): void | |
public function postLoad(LifecycleEventArgs|PostLoadEventArgs $args): void |
or we can even skip the change in function notation. As we are reducing the scope of what is passed and this function is public, we should still allow for the old notation (until we support Doctrine 2.0)
Other option is to add this to psalm configuration