Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doctrine/orm and fix deprecation #546

Open
wants to merge 1 commit into
base: 1.11
Choose a base branch
from

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Dec 27, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

Other option is to add this to psalm configuration

<DeprecatedClass>
            <errorLevel type="info">
                <referencedClass name="Doctrine\ORM\Event\LifecycleEventArgs" /> <!-- deprecated in doctrine/orm 2.14 -->
            </errorLevel>
</DeprecatedClass>

@dannyvw dannyvw requested a review from a team as a code owner December 27, 2022 10:38
@loic425
Copy link
Member

loic425 commented Jan 3, 2023

@lchrusciel For new release, that's great, but to fix the 1.10 build, we need to fix Psalm error only.

@loic425 loic425 mentioned this pull request Jan 3, 2023
GSadee added a commit that referenced this pull request Jan 3, 2023
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

based on #546 comment


Commits
-------

0e73548 Fix build on 1.10
@lchrusciel lchrusciel changed the base branch from poc-new-resource-metadata to 1.11 March 10, 2023 09:26
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "doctrine-orm" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@@ -69,7 +69,7 @@ public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs): void
}
}

public function postLoad(LifecycleEventArgs $args): void
public function postLoad(PostLoadEventArgs $args): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function postLoad(PostLoadEventArgs $args): void
public function postLoad(LifecycleEventArgs|PostLoadEventArgs $args): void

or we can even skip the change in function notation. As we are reducing the scope of what is passed and this function is public, we should still allow for the old notation (until we support Doctrine 2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants