Make appimage be able to work on any linux system (and some refactor of the script). #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make the appimage be able to work on any linux system, be it 15 years old or even musl distros. this is done by bundling all the libraries the nvtop binary needs + the ld-linux.so.
These changes are similar what the deploy everything mode of go-appimage does but I find it far easier to do it manually instead of fighting with the go-appimage parameters though.
Tested on Artix, Alpine (musl) and Ubuntu 20.04 (old Glibc).
The only downside is that this makes the appimage 2.4 MiB.
Also updated the readme to use 24.04 instead of 18.04, because with older versions you had to do stuff like using pip to install a newer cmake, none of this is needed anymore by building the appimage this way.
Edit: I'm linking an artifact if you want to test it, remove the
.txt
from the end.nvtop-3.1.0-x86_64.AppImage.txt