[WIP] Documentation & Evaluator Improvement #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mengliu1998
commented
Jun 5, 2024
•
mengliu1998
commented
- Restructure evaluators and add testing
- Improve documents for evaluators
- Update the SimpleQA code according to the latest code
mengliu1998
force-pushed
the
meng
branch
4 times, most recently
from
4c8edcb to
6de7244
Compare
liyin2015
reviewed
Jun 8, 2024
| """ | ||
|
|
||
| # We use OpenAIClient as the default LLM evaluator if it is available. Otherwise, we set it to None. | ||
| if "OpenAIClient" in globals(): |
There was a problem hiding this comment.
you can let users pass model_client. refer to lightrag/optim/llm_augment.py and lightrag/optim/llm_optimizer.py
liyin2015
reviewed
Jun 8, 2024
| r""" | ||
| Compute the match accuracy of the predicted answer for a list of queries. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
try to add the compute or call, this pr then should be good
liyin2015
reviewed
Jun 8, 2024
|
|
||
| def compute_judgement( | ||
| self, | ||
| all_questions: List[str], |
There was a problem hiding this comment.
all_questions, maybe just questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.