Bootstrap integration tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
commented
Sep 18, 2024
Comment on lines
113
to
121
| // TODO : wait for metrics to be sent and add assertions on what is being captured | ||
| // for now we just test that we can connect to remote JMX using our client. | ||
| try (JMXConnector connector = JmxRemoteClient.createNew(targetHost, targetPort).connect()) { | ||
| assertThat(connector.getMBeanServerConnection()).isNotNull(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| // TODO: replace with real assertions | ||
| assertThat(otlpServer.getMetrics()).isEmpty(); |
There was a problem hiding this comment.
[for reviewer] for now we just test the JMX connection, so it tests if the target system is setup in the way we expect it to be. In future PRs we will replace this with actual assertions on the captured metrics.
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Outdated
Show resolved
Hide resolved
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Show resolved
Hide resolved
SylvainJuge
commented
Sep 18, 2024
robsunday
approved these changes
Sep 18, 2024
...craper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/JmxScraperContainer.java
Outdated
Show resolved
Hide resolved
...craper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/JmxScraperContainer.java
Outdated
Show resolved
Hide resolved
jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/TestAppContainer.java
Outdated
Show resolved
Hide resolved
...est/java/io/opentelemetry/contrib/jmxscraper/target_systems/TargetSystemIntegrationTest.java
Show resolved
Hide resolved
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Outdated
Show resolved
Hide resolved
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.