cran ready

SymbolixAU · May 25, 2018 · f94d402 · f94d402
1 parent cf00f29
commit f94d402
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 24 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: googlePolylines
 Type: Package
 Title: Encoding Coordinates into 'Google' Polylines
-Version: 0.6.0
-Date: 2018-03-11
+Version: 0.6.1
+Date: 2018-05-25
 Authors@R: c(
     person("David", "Cooley", ,"dcooley@symbolix.com.au", role = c("aut", "cre")),
     person("Paulo", "Barcelos", role = "ctb", comment = "Author of c++ decode_polyline")

diff --git a/README.md b/README.md
@@ -16,7 +16,7 @@ A **fast** and light-weight implementation of [Google's polyline encoding algori
 
 ## Installation
 
-Version 0.6.0 is on CRAN and can be installed through
+Version 0.6.1 is on CRAN and can be installed through
 
 ```
 install.packages("googlePolylines")

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,20 +1,15 @@
 
 ## Release summary
 
-* Updates v0.4.0 to v0.6.0
-* `as.data.frame.sfencoded` method
-* `decode` function for decoding polylines
-* Fixed ASAN/UBSAN errors (https://www.stats.ox.ac.uk/pub/bdr/memtests/clang-UBSAN/googlePolylines/build_vignettes.log) and (https://www.stats.ox.ac.uk/pub/bdr/memtests/gcc-UBSAN/googlePolylines/build_vignettes.log) by explicitely defining `unsigned int` value
-* Ran tests, examples and vignettes with Address Sanitizers (ASAN) and Undefined Behaviour Sanitizer (UBSAN) using `rhub::check_with_sanitizers()`
-* Successful ASAN/UBSAN build log: https://builder.r-hub.io/status/googlePolylines_0.6.0.tar.gz-a342c46a4b3b4ed3b7b8017536ab5dae#L1857
+* Updates v0.6.0 to v0.6.1
+* Removed dependencies on undeclared packages from unit tests, as per CRAN request - email "CRAN packages maintained by you" from Kurt Hornik, 2018-05-18
 
 
-## Test environments
+## Test Environments
 
-* local OS X install, R 3.4.3
-* ubuntu 14.04 (on travis-ci), R 3.4.3
+* local OS X 15.6.0 (High Sierra) install, R 3.5.0
+* travis-ci (ubuntu 14.04.5, R Under development r74781)
 * win-builder (devel and release)
-* `rhub::check_with_sanitizers()`
 
 ## R CMD check results
 

diff --git a/tests/testthat/test-Encode.R b/tests/testthat/test-Encode.R
@@ -11,17 +11,6 @@ test_that("google's example encodes correctly", {
   expect_true(encode(df) == "_p~iF~ps|U_ulLnnqC_mqNvxq`@")
 })
 
-test_that("answers are same as other implementations", {
-
-  testthat::skip_on_cran()
-  testthat::skip_on_travis()
-
-  df <- data.frame(lat = c(38.5, 40.7, 43.252),lon = c(-120.2, -120.95, -126.453))
-  expect_true(gepaf::encodePolyline(df) == encode(df))
-  df <- data.frame(lat = c(41.8249, 41.8300, 41.8288, 41.8339, 41.8380),
-                   lon = c(-87.7200, -87.7043, -87.6940, -87.6833, -87.6703))
-  expect_true(gepaf::encodePolyline(df) == encode(df))
-})
 
 test_that("encode coordinates algorithim works", {