Skip to content

Commit

Permalink
patches for #29 and #27
Browse files Browse the repository at this point in the history
  • Loading branch information
SymbolixAU committed Aug 14, 2018
1 parent f16fa9c commit 1dfb182
Show file tree
Hide file tree
Showing 28 changed files with 30 additions and 28 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
^\.travis\.yml$
^codecov\.yml$
^cran-comments\.md$
^javascript$
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: mapdeck
Type: Package
Title: Interactive Maps Using 'Mapbox GL JS' and 'Deck.gl'
Version: 0.1.1
Version: 0.1.0
Date: 2018-08-11
Authors@R: c(
person("David", "Cooley", ,"dcooley@symbolix.com.au", role = c("aut", "cre"))
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_arc.R
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ mapdeckArcDependency <- function() {
#' @param palette a function which generates hex colours
#'
#' @examples
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_geojson.R
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ mapdeckGeojsonDependency <- function() {
#'
#'
#' @examples
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_grid.R
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ mapdeckGridDependency <- function() {
#' @param elevation_scale cell elevation multiplier
#'
#' @examples
#' \dontrun{
#' \donttest{
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
#'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_line.R
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ mapdeckLineDependency <- function() {
#' @param stroke_colour variable or hex colour to use as the ending stroke colour
#'
#' @examples
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_path.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ mapdeckPathDependency <- function() {
#' between 1 and 255 to be applied to all the shapes
#'
#' @examples
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_pointcloud.R
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ mapdeckPointcloudDependency <- function() {
#' @param light_settings list of light setting parameters. See \link{light_settings}
#'
#' @examples
#' \dontrun{
#' \donttest{
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
#'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_polygon.R
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ mapdeckPolygonDependency <- function() {
#' @param tooltip variable of \code{data} containing text or HTML to render as a tooltip
#'
#' @examples
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_scatterplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ mapdeckScatterplotDependency <- function() {
#'
#' @examples
#'
#'\dontrun{
#' \donttest{
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
#'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_screengrid.R
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ mapdeckScreengridDependency <- function() {
#' @param cell_size size of grid squares in pixels
#'
#' @examples
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/map_layer_text.R
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ mapdeckTextDependency <- function() {
#'
#' @examples
#'
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/map_styles.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#' @param style one of streets, outdoors, light, dark, satellite, satellite-streets
#'
#' @examples
#' \dontrun{
#' \donttest{
#'
#' ## You need a valid access token from Mapbox
#' key <- 'abc'
Expand Down
2 changes: 1 addition & 1 deletion R/mapdeck_package.R
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#' @export
#' @param lhs,rhs A google map and a layer to add to it
#' @examples
#' \dontrun{
#' \donttest{
#'
#' key <- "your_api_key"
#' mapdeck_map(key = key) %>%
Expand Down
3 changes: 2 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
## Comments

* Updated all examples from `\dontrun` to `\donttest`
* Updated description with details about Mapbox GL and Deck gl
* All examples are `dontrun` because they all require internet connection
* All examples are `donttest` because they all require internet connection


## Test environments
Expand Down
4 changes: 2 additions & 2 deletions inst/htmlwidgets/mapdeck.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ HTMLWidgets.widget({

renderValue: function(x) {

window.params = [];
window.params.push({ 'map_id' : el.id });
//window.params = [];
//window.params.push({ 'map_id' : el.id });

window[el.id + 'layers'] = []; // keep track of layers for overlaying multiple
// needs to be an array because .props takes an array of layers
Expand Down
2 changes: 1 addition & 1 deletion man/add_arc.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_geojson.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_grid.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_line.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_path.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_pointcloud.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_polygon.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_scatterplot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_screengrid.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/add_text.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/mapdeck_style.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/pipe.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1dfb182

Please sign in to comment.