Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub rate limit with cache #55

Merged
merged 5 commits into from
May 21, 2024
Merged

Fix GitHub rate limit with cache #55

merged 5 commits into from
May 21, 2024

Conversation

eminjk
Copy link
Contributor

@eminjk eminjk commented May 15, 2024

fix for #43 using cache and storing the latest version for 1h

I don't think we need both solutions and this one is way better than the authenticated request so feel free to close the other one.

@eminjk eminjk mentioned this pull request May 21, 2024
Closed
bocharsky-bw
bocharsky-bw approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered this solution after the one with GITHUB_TOKEN.

Yeah, agree, I think this solution is better and we don't need both solutions unless we have a use case when it's really needed.

@bocharsky-bw bocharsky-bw changed the title GitHub rate limit with cache Fix GitHub rate limit with cache May 21, 2024
@bocharsky-bw bocharsky-bw merged commit 1c075f2 into SymfonyCasts:main May 21, 2024
11 checks passed
@bocharsky-bw
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eminjk @bocharsky-bw