Syncplay can unknowingly uses old VLC lua script

[Et0h]

Syncplay 1.4.0 fixed issue #108 back in January 2017, preventing erroneous jumps from VLC that were caused by VLC changing the unit used for reporting position.

The Syncplay installer will place the newest version of syncplay.lua in the %PROGRAMFILES% folder which will resolve the issue. Normally this is fine, but if someone has an old version of syncplay.lua in their VLC %APPDATA% folder then VLC will use that in favour of the more recent version in %PROGRAMFILES%.

Even worse, Syncplay won't notice it's on an old version, meaning on some version mismatches it will act incorrectly without the user knowing why.

[NotActuallyTerry]

For purposes of having Google return this issue to people trying to debug, these are the relevant Notifications:

[10:34:35 PM] jumped from 2d, 12:25:45 to 3d, 16:27:53  
[10:34:35 PM] jumped from 3d, 16:27:53 to 6d, 11:27:06  
[10:34:36 PM] jumped from 6d, 11:27:06 to 10:19:56 (Title 1)  
[10:34:36 PM] jumped from 10:19:56 (Title 1) to 2d, 20:17:55 (Title 1)  
[10:34:36 PM] jumped from 2d, 20:17:55 (Title 1) to 3d, 07:51:06 (Title 1)  
[10:34:36 PM] jumped from 3d, 07:51:06 (Title 1) to 5d, 06:28:55 (Title 1)  
[10:34:36 PM] jumped from 5d, 06:28:55 (Title 1) to 6d, 05:29:49 (Title 1)  
[10:34:36 PM] jumped from 6d, 05:29:49 (Title 1) to 2d, 02:56:29 (Title 2)  
[10:34:36 PM] jumped from 2d, 02:56:29 (Title 2) to 4d, 01:33:51 (Title 2)  
[10:34:37 PM] jumped from 4d, 01:33:51 (Title 2) to 5d, 00:22:30 (Title 2)  
[10:34:37 PM] jumped from 5d, 00:22:30 (Title 2) to 10:26:34 (Title 3)  
[10:34:37 PM] jumped from 10:26:34 (Title 3) to 21:55:00 (Title 3)  

This issue happened to me, even though I started using Syncplay at 1.5.3

[benplumley]

Just downloaded 1.6.0 and this caught me out, even though I downloaded both the application and the Lua script fresh today. The cause of this, for me, was that the script in the VLC addon repository is not up-to-date.

Edit: if the addon from the VLC repository is not needed any more, to the point where it's no longer updated (because SyncPlay can use its own copy), perhaps it should be removed from VLC's repository to prevent this from happening to new users who only discover it via VLC.

[Et0h]

@benplumley Thank you for letting me know that the version in the VLC repository needed updating. I have now updated the version in the VLC repository.

[Et0h]

Currently working on https://github.com/Syncplay/syncplay/commits/vlc-copy-intf to resolve this issue. If anyone wants to test it then let me know how it goes.

[Et0h]

#220 hopefully resolves this issue.