Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay pauses after every youtube video #334

Closed
Canageek opened this issue Jul 11, 2020 · 1 comment
Closed

Syncplay pauses after every youtube video #334

Canageek opened this issue Jul 11, 2020 · 1 comment

Comments

@Canageek
Copy link

Expected behaviour: When syncplay reaches the end of one video, it starts the next
Observed behaviour: When syncplay reaches the end of a youtube video, it pauses and needs to be manually unpaused.

To duplicate: Using VLC or mpv (Other players not tested) load two youtube videos onto a syncplay playlist. Start the first one, observe how it does not advanced to the next video in the same manner as it does for local files.

@Et0h
Copy link
Contributor

Et0h commented Mar 4, 2021

This has taken some time to work on because it involved in reworking some core Syncplay code and figuring out how best to update custom player-side interfaces. However, I now have PR #397 which hopefully resolves the issues you raised.

Please test the PR and let me know if it fixes your problems. I'm closing this issue so that the conversation can more to the pull request.

@Et0h Et0h closed this as completed Mar 4, 2021
Et0h added a commit that referenced this issue Mar 28, 2021
* Advance playlist on end of file in mpv and VLC
* Update duration for streams to fix playlist advancement (#334)
Et0h added a commit that referenced this issue Aug 2, 2021
* Create pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Do not show playback speed change notifications in OSD

* Upbuild and remove debug message

* Strip quotation marks from per-player arguments (#226)

* Delete unmaintained changelog.

Removing old and unmaintained changelog file.

* Add more MPC-HC paths (#398)

* Migrate from AppVeyor to GitHub Actions (#399)

* Disable AppVeyor

* Actions: disable other jobs

* Actions: implement windows job

* Use requirements

* Typo in version parser

* Replace type nul for PowerShell

* Change Python version to 3.7

* buildPy2exe: exclude tcl and tkinter

* buildPy2exe: rename zip archive to include extension

* Actions for Windows: build on Python 3.8

* Re-enable build flow for other platforms

* Remove AppVeyor configuration file

* Add manpages courtesy of Bruno Kleinert #387

* Install the manpages.

* Separate debian package artifacts

Make it so that server and full packages are separate artifacts in CI rather than single zip containing both.

* Fix server deb deployment name in CI workflow

* Fix package filename for debs

* Update mpv json ipc vendor code

Update to version 1.1.13 to hopefully address #322 fully.

* Update setup.py for vendor code of mpv jsonipc

* Build AppImage on Ubuntu 18.04

Temporary workaround for AppImage built on Ubuntu 20.04 crashing with segmentation fault. #401

* Update python_mpv_jsonipc to 1.1.13 keeping our changes

* Remove the AppVeyor badge as we stopped using it.

* Improve playlist advancement for VLC and mpv (#334) (#397)

* Advance playlist on end of file in mpv and VLC
* Update duration for streams to fix playlist advancement (#334)

* Add notice for Python in third party collection file (#404)

* Add notice for Python in third party collection file

* Convert third party notices file to plain text

* Adapt codebase to third party notices format change

* Mark as beta 1 (release 97)

* Mark as 1.6.8 final (build 98)

* Update pt_BR translation, fix typo (#422)

* Bundle libgthread-2.0.so.0 into AppImage

* add libxcb manually

* Add missing libxcb-util to build environment

* Enable GitHub Actions on pull requests

* Bundle libxcb1 into AppImage to fix #380

* Send 32-bit/64-bit context when updating

* Upver to 1.6.9 release 99

* Remove references to IRC (#430)

* Add reference to GitHub discussions

* Update issue templates

* Revert "Merge branch 'master' into master"

This reverts commit 173007e, reversing
changes made to 6105da8.

Co-authored-by: Daniel Wróbel <wrobel.dan@gmail.com>
Co-authored-by: Alberto Sottile <alby128@gmail.com>
Co-authored-by: Daniel Wróbel <1662391+daniel-123@users.noreply.github.com>
Co-authored-by: Atílio Antônio <atiliodadalto@hotmail.com>
Co-authored-by: Teoh Han Hui <teohhanhui@gmail.com>
Co-authored-by: Alberto Sottile <asottile@gmail.com>
Co-authored-by: Assistant <assistant.moetron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants