-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Current Offset in Set Offset #642
Comments
That's a great idea as it improves usability for those who set offsets, doesn't have any backwards compatibility issues, and is easy to implement. As such, I've made the change and it will be included in Syncplay 1.7.1. You can test it out at https://github.com/Syncplay/syncplay/actions/runs/6816222476 |
@Xeiv Can you please test the feature and confirm that it works as expected. |
Yep it's working pretty well! 😄 I don't know if it's related but when I use decimals and put something like 10.50, it will set it as 10.05 and 10.5 sets it as 10.005, 10.500 sets it correctly though. |
@Xeiv Thanks for testing this. I think the problem you identified was a pre-existing bug rather than something introduced by these changes. I've hopefully fixed it, though. Please try https://github.com/Syncplay/syncplay/actions/runs/6883506778 once it has finished building and let me know. |
@Et0h Yeah, it's fixed now, thank you 👍 |
Excellent, in that case I'll close this issue as resolved. |
Hello, I'd like to request to show the currently set offset in the set offset popup windows.
Sometimes the offset needs to be changed mid playback but when it's been paused/seeked multiple times you need to search for the current offset in the middle of it all which is kinda tedious.
If the Current Offset would be shown in the Set Offset popup it would be easy to know what it is and adjust accordingly.
The text was updated successfully, but these errors were encountered: