Opportunistic TLS support #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the guidelines reported in the Twisted documentation here https://twistedmatrix.com/documents/current/core/howto/ssl.html this commit enables Diffie-Hellman based key exchange on the server. Before launching the server, a parameters .pem file must be generated as detailed in https://twistedmatrix.com/documents/18.9.0/api/twisted.internet.ssl.DiffieHellmanParameters.html by running `openssl dhparam -out dh_param_1024.pem -2 1024` on the server machine. This parameters file must be placed in the same path that contains the server certificates.
Following the guidelines reported in the Twisted documentation here https://twistedmatrix.com/documents/current/core/howto/ssl.html this commit enables Diffie-Hellman based key exchange on the server. Before launching the server, a parameters .pem file must be generated as detailed in https://twistedmatrix.com/documents/18.9.0/api/twisted.internet.ssl.DiffieHellmanParameters.html by running `openssl dhparam -out dh_param_1024.pem -2 1024` on the server machine. This parameters file must be placed in the same path that contains the server certificates.
… happening in dual stack configurations
|
I'm really excited for this revision. :D Finally we'll have secure connections! I just wanted to say I really appreciate your work. Thanks :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #217. Further details in the wiki and soon in the website.
It also supports a dual stack IPv4 and IPv6 listener on the server using Twisted endpoints and proper error handling.