Config dialog: Remove 'update list' button and tweak sizes #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertosottile
pushed a commit
to albertosottile/syncplay
that referenced
this pull request
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the 'update server list' and changes some of the GUI heights/widths to make it look tidier.
We don't have third party servers at the moment and it checks for them when it looks for updates anyway, so I think the button is unnecessary clutter at present.
Removing it meant we didn't need so much width, but I also noticed that reworking the code then meant the height was a bit short in non-advanced mode on some DPIs so I made it taller for text not to be clipped off in the input boxes.
The tweak also ensures that the executable path input box is aligned with those from the other group box, to avoid an issue where in non-advanced mode it was a bit too far to the left.
I've only tested this on Windows, so if you can test this on other OS to see if the GuiConfig looks okay then that would be appreciated!