Room history

[Gbd199]

No description provided.

[Et0h]

Hi,

I have long wanted for a feature such as this so thanks for helping to move it forwards.

Firstly, I've tested and it works. The behaviour is that it lists the rooms you connect to the server with and then provides them as options from the GuiConfig window for future connections, irrespective of server. As far as it goes, this is a reasonable behaviour because trying to make it per-server arguably adds unnecessary complexity when people might use the same room names across multiple servers

Suggestions for consideration/discussion:

• The ability to delete a room from the list of rooms.
• Allow users to select from the list of rooms once connected, e.g. by making the textbox in the main Syncplay window next to 'Join room' also be a combo box.
• Remember rooms you connect to from the main Syncplay window
• When you create a managed room, also remember the version with the auto-identification in it, e.g. +RoomName:868A81271506:NX-914-891
• An alternative approach to auto-remembering the room names would be to have a 'favourites' system where, once connected, you can add a room to your list of favourites and then manage that list. This will prevent the list from getting clogged up so requires less user action to clear it, but on the other hand does require users to manually click to remember a room which they might forget to do. Which is more convenient and intuitive?

[Gbd199]

thanks for the feedback, I'll see what I can do over the weekend

[Gbd199]

I decided to go with a list view dialog for the rooms. This gives the user complete and simple control over the rooms and did not require too many changes. Due to the simple control I think adding a 'favorite rooms' mechanism is pointless, but tell me what you think.

[Et0h]

Allowing people to edit, add and delete rooms via a multiline textbox dialog makes sense, not least because it is in line with what we do for trusted domains and the playlist. I'll try out your latest version and give it some consideration. Something I'll be thinking about is whether there needs to be an easy way to enable/disable the feature automatically remembering room names.

[Et0h]

Thought about it, and I think the only thing it really needs is to be able to turn off auto-remembering. If nobody has any further comments/objections then when I have time I'll merge the changes and add any final tweaks myself.

[Gbd199]

Allow users to select from the list of rooms once connected, e.g. by making the textbox in the main Syncplay window next to 'Join room' also be a combo box.

Remember rooms you connect to from the main Syncplay window

I looked into it and found some issues with that.
First of all, purely changing the Input into a combobox is fairly simple.
But when it comes to remembering the rooms I encountered a problem, in the current version, if in the main window you join a new room, it will not save it in the configuration for you to see as the default room next time you start syncplay.
Remembering rooms from the main window will require fixing that issue first, which is not hard but does require some changes and proof testing since I'm not familiar with the more complicated functionality of syncplay and might easily miss and mess with some feature.
And it will also require setting room/roomhistory configuration logic in client.py(in a method similar in its idea to setTrustedDomains()) so gui.py can access it.

So in my opinion, as for this pull request, changing the input into a combobox should be enough. Remembering the history form the main window, and fixing the issue I pointed out should be addressed in a new issue.
But tell me what you think

[Et0h]

Further discussion take take place on #336