Add initial Finnish translation (credit: LINUX-SAUNA) #561

Et0h · 2022-11-03T19:50:51Z

No description provided.

Mikaela

I think a lot of this translation is strange or has mistakes even in easier to translate spots, but it's difficult to comment without having the original side by side. I provided some examples in the review that instantly hit my eyes without scrolling that far down.

For example the Windows NSIS installer bothers me as "shortcuts" have been "pikakuvakkeet" as far as I can remember, while the translation introduces a new term that is not an established part of Finnish localization.

See also: tchx84/Flatseal#497 from the same author while I find the comments there upsetting and discouraging from localizing Finnish in general and also in poor taste for being in Finnish that is not established language of the project.

Mikaela · 2022-11-05T13:32:29Z

syncplay/messages_fi.py

+     # Strings for Windows NSIS installer
+     "installer-language-file": "Finnish.nlf", # Relevant .nlf file at https://github.com/kichik/nsis/tree/master/Contrib/Language%20files
+     "installer-associate": "Yhdistä Syncplay toimimaan multimedia-tiedostojen kanssa.",
+     "installer-shortcut": "Luo oikopolut seuraaviin kohteisiin:",


Suggested change

"installer-shortcut": "Luo oikopolut seuraaviin kohteisiin:",

"installer-shortcut": "Luo pikakuvakkeet kohteisiin:",

Mikaela · 2022-11-05T13:33:29Z

syncplay/messages_fi.py

+     # Client notifications
+     "config-cleared-notification": "Asetukset pyyhitty. Muutokset tallennetaan kun toimitat uuden kelvollisen asetuskokonaisuuden.",
+
+     "relative-config-notification": "Asiaankuuluva asetustiedosto(t) ladattu: {}",


I think this is somewhat clumsy way to express this, if it's "asetustiedosto(t)", shouldn't it also be "Asiaankuuluva(t)"?

These are minor mistakes, so why can't you just correct them when spotted? All this is cooperative work.

These are minor mistakes, so why can't you just correct them when spotted? All this is cooperative work.

As far as I can see, you have not been involved in making these translations (or Flatseal translations). You have only commented on either misinformation or tried to label the problems presented by others in translations as "minor". Stop the bothering, it's starting to feel like you're just a LINUX-SAUNA alt user.

These are minor mistakes, so why can't you just correct them when spotted? All this is cooperative work.

As far as I can see, you have not been involved in making these translations (or Flatseal translations). You have only commented on either misinformation or tried to label the problems presented by others in translations as "minor". Stop the bothering, it's starting to feel like you're just a LINUX-SAUNA alt user.

Excuse me? To request a correction upon finding a mistake with minor thing such as brackets is bothering? What is with that strange offensive attitude of yours.

The base work is done and mistakes are to be corrected, just as usual. For your information, LINUX-SAUNA is a little community that helps new comers on Linux and also does occasional translations to projects where there is 0% Finnish such as this project. Not professional translators. I did couple of sections on this one too, so.

I think you're taking this too emotionally.

These are minor mistakes, so why can't you just correct them when spotted? All this is cooperative work.

As far as I can see, you have not been involved in making these translations (or Flatseal translations). You have only commented on either misinformation or tried to label the problems presented by others in translations as "minor". Stop the bothering, it's starting to feel like you're just a LINUX-SAUNA alt user.

Excuse me? To request a correction upon finding a mistake with minor thing such as brackets is bothering? What is with that strange offensive attitude of yours.

You can translate it however you want, but this and the Flatsea'sl issue show how you repeatedly downplay the massive errors in the translation, which the majority of those who participated in the discussion have acknowledged. Please, just stop it.

The base work is done and mistakes are to be corrected, just as usual.

Where does this appear? You have not corrected obvious translation errors, but you are trying to include it in the project as it is, or at least you have left all the translation correction work on the shoulders of others. And softwares are not developed in such a way that I add this piece to the software, even though I know it is full of problems and I will (maybe) fix it later. Check out software development and you'll know.

For your information, LINUX-SAUNA is a little community that helps new comers on Linux and also does occasional translations to projects where there is 0% Finnish such as this project. Not professional translators.

Okay, based on your translations, you are frankly not ready to participate in translation work.

I did couple of sections on this one too, so.

Source for this?

I think you're taking this too emotionally.

A matter of opinion, but the truth is still that you should now sit down with your translations, when the level of your translations will be noticed in two projects in one week.

Mikaela · 2022-11-05T13:35:38Z

syncplay/messages_fi.py

+     "rewind-notification": "Taaksepäin kelattu koska ilmeni aikaero {}",  # User
+     "fastforward-notification": "Pikakelaus eteenpäin koska ilmeni aikaero {}",  # User


using the word "koska" ("because") requires a comma and I think these would be better expressed:

Suggested change

"rewind-notification": "Taaksepäin kelattu koska ilmeni aikaero {}", # User

"fastforward-notification": "Pikakelaus eteenpäin koska ilmeni aikaero {}", # User

"rewind-notification": "Kelattiin taaksepäin aikaeron {} vuoksi", # User

"fastforward-notification": "Pikakelattiin eteenpäin aikaeron {} vuoksi", # User

So go ahead? I think this translation should be gotten in and into polishing it all the time, then.

Et0h · 2022-11-05T16:05:04Z

I think a lot of this translation is strange or has mistakes even in easier to translate spots, but it's difficult to comment without having the original side by side.

@Mikaela I see how it can be difficult to compare the translation with the English. As such, I've now created a script for messages.py to print the messages in multiple languages and have run it it to English/Finnish to support comparison. See Finnish Translation Comparison (Original).txt for the results.

The code I wrote was:

def listMessages(languages):
    languageNames = []
    for language in languages:
        languageNames.append(messages[language]["LANGUAGE"])
    comparison = "Listing Syncplay messages in the following languages: {}.\n".format(", ".join(languageNames))
    for message in messages["en"]:
        comparison = comparison + "[{}]\n".format(message)
        for language in languages:
            languageName = messages[language]["LANGUAGE"]
            messageText = messages[language][message] if message in messages[language] else "<UNTRANSLATED>"
            comparison = comparison + "{}: {}\n".format(languageName, messageText)
        comparison = comparison + "\n"
    return comparison

print(listMessages(["en","fi"]))

See also: tchx84/Flatseal#497 from the same author while I find the comments there upsetting and discouraging from localizing Finnish in general and also in poor taste for being in Finnish that is not established language of the project.

The author wanted me to credit LINUX-SAUNA and stated that it was a "Finnish all-round Linux-helping community" (of which they were presumably associated). As such, I am not sure if there is any direct relationship between the author of the Syncplay translation and the author of those comments other than them both being associated with the same online community.

Mikaela

I am working on attempting to improve this translator in #563, but I am not able to focus on it 24/7 nor am I able to do it all in one go or give any timeline schedules.

Mikaela · 2022-11-06T14:19:42Z

syncplay/messages_fi.py

+     # Client notifications
+     "config-cleared-notification": "Asetukset pyyhitty. Muutokset tallennetaan kun toimitat uuden kelvollisen asetuskokonaisuuden.",
+
+     "relative-config-notification": "Asiaankuuluva asetustiedosto(t) ladattu: {}",


Mikaela · 2022-11-06T14:20:12Z

syncplay/messages_fi.py

+     "rewind-notification": "Taaksepäin kelattu koska ilmeni aikaero {}",  # User
+     "fastforward-notification": "Pikakelaus eteenpäin koska ilmeni aikaero {}",  # User


karpse · 2022-11-06T15:32:05Z

I think a lot of this translation is strange or has mistakes even in easier to translate spots, but it's difficult to comment without having the original side by side. I provided some examples in the review that instantly hit my eyes without scrolling that far down.

For example the Windows NSIS installer bothers me as "shortcuts" have been "pikakuvakkeet" as far as I can remember, while the translation introduces a new term that is not an established part of Finnish localization.

See also: tchx84/Flatseal#497 from the same author while I find the comments there upsetting and discouraging from localizing Finnish in general and also in poor taste for being in Finnish that is not established language of the project.

Be that as it may, I don't think the translation of this author(s?) can be merged without checking it thoroughly. I looked other translations by this LINUX-SAUNA GitHub user and it seems that his way of translating is, well, peculiar. And despite the feedback, the translation style does not seem to have changed in this translation.

My previous examples already tell enough, LINUX-SAUNA translated "documentation" -> "selonteko", "permissions" -> "luvitus", "syscall" -> "järjestelmäkäsky" (established term is "järjestelmäkutsu"; and "käsky" is technically incorrect, because the userland program cannot "käskeä" kernel, it "kutsuu" or "pyytää"), handling the D-Bus vocabulary carelessly and translated "xdg-pictures" -> "xdg-kuvat" which is a variable that has no translation and really shouldn't be translated. I think that the user is excited about her/his new hobby and wants to renew the vocabulary, but it doesn't work if there is no IT expertise. In addition to this, I also saw some careless mistakes.

* syncplay/messages_fi.py: begin reading through * messages_fi.py: address feedback * messages_fi.py: continue readthrough * messages_fi.py: correct a couple of errors noticed earlier

Et0h · 2023-03-11T18:12:43Z

This translation has now been updated in line with changes provided by @Mikaela.

It would be helpful if someone could check out the updated build for this PR at https://github.com/Syncplay/syncplay/actions/runs/4296941535 and confirm that the installer and client work correctly in Finnish.

Add initial Finnish translation (credit: LINUX-SAUNA)

77ddfc5

Mikaela suggested changes Nov 5, 2022

View reviewed changes

Mikaela mentioned this pull request Nov 5, 2022

[WIP] Correct Finnish localizations #563

Merged

Mikaela reviewed Nov 6, 2022

View reviewed changes

karpse mentioned this pull request Nov 6, 2022

Add Finnish translation tchx84/Flatseal#497

Closed

albertosottile added the enhancement label Dec 22, 2022

[WIP] Correct Finnish localizations (#563)

871f7cf

* syncplay/messages_fi.py: begin reading through * messages_fi.py: address feedback * messages_fi.py: continue readthrough * messages_fi.py: correct a couple of errors noticed earlier

Et0h merged commit 0f58909 into master Mar 14, 2023

Et0h deleted the Finnish_Translation branch March 14, 2023 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial Finnish translation (credit: LINUX-SAUNA) #561

Add initial Finnish translation (credit: LINUX-SAUNA) #561

Et0h commented Nov 3, 2022

Mikaela left a comment

Mikaela Nov 5, 2022

Mikaela Nov 5, 2022

heidiwenger Nov 6, 2022

Mikaela Nov 6, 2022

karpse Nov 6, 2022 •

edited

Loading

heidiwenger Nov 8, 2022

karpse Nov 9, 2022

Mikaela Nov 5, 2022

heidiwenger Nov 6, 2022

Mikaela Nov 6, 2022

Et0h commented Nov 5, 2022 •

edited

Loading

Mikaela left a comment

Mikaela Nov 6, 2022

Mikaela Nov 6, 2022

karpse commented Nov 6, 2022 •

edited

Loading

Et0h commented Mar 11, 2023 •

edited

Loading

	"installer-shortcut": "Luo oikopolut seuraaviin kohteisiin:",
	"installer-shortcut": "Luo pikakuvakkeet kohteisiin:",

		"rewind-notification": "Taaksepäin kelattu koska ilmeni aikaero {}", # User
		"fastforward-notification": "Pikakelaus eteenpäin koska ilmeni aikaero {}", # User

Add initial Finnish translation (credit: LINUX-SAUNA) #561

Add initial Finnish translation (credit: LINUX-SAUNA) #561

Conversation

Et0h commented Nov 3, 2022

Mikaela left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karpse Nov 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Et0h commented Nov 5, 2022 • edited Loading

Mikaela left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karpse commented Nov 6, 2022 • edited Loading

Et0h commented Mar 11, 2023 • edited Loading

karpse Nov 6, 2022 •

edited

Loading

Et0h commented Nov 5, 2022 •

edited

Loading

karpse commented Nov 6, 2022 •

edited

Loading

Et0h commented Mar 11, 2023 •

edited

Loading