Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More appimage bases #570

Closed
wants to merge 12 commits into from
13 changes: 11 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ jobs:
pip3 download --platform macosx_10_10_universal2 --only-binary :all: --no-deps --dest . cryptography
pip3 install --no-cache-dir --no-index --find-links . cryptography

pip3 uninstall charset-normalizer -y
pip3 download --platform macosx_10_9_universal2 --only-binary :all: --no-deps --dest . charset-normalizer
pip3 install --no-cache-dir --no-index --find-links . charset-normalizer

- name: Check Python dependencies
run: |
python3 -c "from PySide6 import __version__; print(__version__)"
Expand Down Expand Up @@ -135,17 +139,22 @@ jobs:

appimage:
name: Build AppImage
runs-on: ubuntu-18.04
strategy:
matrix:
os: [ubuntu-22.04, ubuntu-20.04, ubuntu-18.04]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Install dependencies
run: |
sudo add-apt-repository universe
sudo apt-get install --no-install-recommends \
libglib2.0-0 \
libxkbcommon-x11-0 \
libxcb1 \
fuse \
;

- name: Build
Expand All @@ -163,7 +172,7 @@ jobs:
- name: Deploy
uses: actions/upload-artifact@v2
with:
name: Syncplay-${{ env.VER }}-x86_64.AppImage
name: Syncplay-${{ env.VER }}-${{ matrix.os }}-x86_64.AppImage
path: |
dist_actions/Syncplay-${{ env.VER }}-x86_64.AppImage

Expand Down
2 changes: 1 addition & 1 deletion buildPy2app.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
OPTIONS = {
'iconfile': 'syncplay/resources/icon.icns',
'extra_scripts': 'syncplayServer.py',
'includes': {'PySide2.QtCore', 'PySide2.QtUiTools', 'PySide2.QtGui', 'PySide2.QtWidgets', 'certifi', 'cffi', 'pem'},
'includes': {'PySide2.QtCore', 'PySide2.QtUiTools', 'PySide2.QtGui', 'PySide2.QtWidgets', 'certifi', 'cffi', 'pem', 'charset_normalizer.md__mypyc'},
'excludes': {'PySide', 'PySide.QtCore', 'PySide.QtUiTools', 'PySide.QtGui', 'tkinter'},
'qt_plugins': [
'platforms/libqcocoa.dylib',
Expand Down
3 changes: 0 additions & 3 deletions ci/appimage-script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ export OUTPUT=Syncplay-$VERSION-x86_64.AppImage
-e $(which readelf) \
-i "$REPO_ROOT"/syncplay/resources/syncplay.png -d pl.syncplay.syncplay.desktop \
--output appimage --custom-apprun AppRun.sh \
-l /usr/lib/x86_64-linux-gnu/libgthread-2.0.so.0 \
-l /usr/lib/x86_64-linux-gnu/libxkbcommon-x11.so.0 \
-l /usr/lib/x86_64-linux-gnu/libxcb.so.1 \
;

mv Syncplay*.AppImage "$OLD_CWD"
4 changes: 2 additions & 2 deletions syncplay/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
version = '1.7.0'
revision = ' release candidate 1'
revision = ''
milestone = 'Yoitsu'
release_number = '103'
release_number = '105'
projectURL = 'https://syncplay.pl/'
4 changes: 2 additions & 2 deletions syncplay/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1124,8 +1124,8 @@ def checkForUpdate(self, userInitiated):
publicServers = ast.literal_eval(publicServers)
return response["version-status"], response["version-message"] if "version-message" in response\
else None, response["version-url"] if "version-url" in response else None, publicServers
except:
return "failed", getMessage("update-check-failed-notification").format(syncplay.version), constants.SYNCPLAY_DOWNLOAD_URL, None
except Exception as e:
return "failed", str(e)+"\n-----\n"+getMessage("update-check-failed-notification").format(syncplay.version), constants.SYNCPLAY_DOWNLOAD_URL, None

class _WarningManager(object):
def __init__(self, player, userlist, ui, client):
Expand Down
4 changes: 2 additions & 2 deletions syncplay/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def getValueForOS(constantDict):
UI_TIME_FORMAT = "[%X] "
CONFIG_NAMES = [".syncplay", "syncplay.ini"] # Syncplay searches first to last
DEFAULT_CONFIG_NAME = "syncplay.ini"
RECENT_CLIENT_THRESHOLD = "1.6.8" # This and higher considered 'recent' clients (no warnings)
RECENT_CLIENT_THRESHOLD = "1.7.0" # This and higher considered 'recent' clients (no warnings)
MUSIC_FORMATS = [".mp3", ".m4a", ".m4p", ".wav", ".aiff", ".r", ".ogg", ".flac"] # ALL LOWER CASE!
WARN_OLD_CLIENTS = True # Use MOTD to inform old clients to upgrade
LIST_RELATIVE_CONFIGS = True # Print list of relative configs loaded
Expand Down Expand Up @@ -96,7 +96,7 @@ def getValueForOS(constantDict):

# Max numbers are used by server (and client pre-connection). Once connected client gets values from server featureList (or uses 'fallback' versions for old servers)
MAX_CHAT_MESSAGE_LENGTH = 150 # Number of displayed characters
MAX_USERNAME_LENGTH = 150 # Number of displayed characters
MAX_USERNAME_LENGTH = 16 # Number of displayed characters
MAX_ROOM_NAME_LENGTH = 35 # Number of displayed characters
MAX_FILENAME_LENGTH = 250 # Number of displayed characters
FALLBACK_MAX_CHAT_MESSAGE_LENGTH = 50 # Number of displayed characters
Expand Down
4 changes: 2 additions & 2 deletions syncplay/ui/gui.py
Original file line number Diff line number Diff line change
Expand Up @@ -1902,8 +1902,8 @@ def automaticUpdateCheck(self):
timeDelta = currentDateTimeValue.toPython() - self.lastCheckedForUpdates.toPython()
if timeDelta.total_seconds() > constants.AUTOMATIC_UPDATE_CHECK_FREQUENCY:
self.checkForUpdates()
except:
self.showDebugMessage("Automatic check for updates failed. An update check was manually trigggered.")
except Exception as e:
self.showDebugMessage("Automatic check for updates failed. An update check was manually trigggered. Reason: {}".format(str(e)))
self.checkForUpdates()

def userCheckForUpdates(self):
Expand Down