-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MPV socket getting created in CWD #675
Conversation
6e94def
to
0690aa1
Compare
f6fec7c
to
7280bb7
Compare
7280bb7
to
df33187
Compare
Overall I think the PR looks quite reasonable with one caveat: the python_mpv_jsonipc.py is technically vendored from https://github.com/iwalton3/python-mpv-jsonipc It would be best if Syncplay didn't add too much of its own things to jsonipc, but on the other hand I don't think anybody else uses that library to begin with and we already made some changes to it. So it's not like this is a blocker of any kind, just something to be aware of and documented in this PR. |
I could pass the socket path via the Edit: I updated the PR. Let me know if there's anything else. |
df33187
to
1f1cbc6
Compare
1f1cbc6
to
6c5e3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested in Windows by confirming that mpv works and by using using Power Shell and [System.IO.Directory]::GetFiles("\\.\\pipe\\")
to confirm that by default it will create a pipe along the lines of \\.\\pipe\\syncplay-mpv-94244417144407
but that if you add a player argument such as input-ipc-server=\\.\pipe\foobar
it will also create a pipe of the specified name.
Thanks @notpeelz and @daniel-123 for your work on this. Time to accept those changes! :-) |
Fixes #674
I haven't tested on Windows or MacOS.