Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $NUKO token #42

Merged
merged 10 commits into from
Jul 19, 2024
Merged

Add $NUKO token #42

merged 10 commits into from
Jul 19, 2024

Conversation

takeshi-nuko
Copy link
Contributor

@takeshi-nuko takeshi-nuko commented Jul 18, 2024

ASCAN Token Submission

Introduction

Before submitting this PR, ensure you have followed all the requirements below and filled out all necessary details about your token.

Checklist

Please review the checklist below and check each item before submitting your token information:

  • I have reviewed the submission guidelines.
  • The submitted files are in the correct format and fulfill all requirements outlined below.

Asset Details

General Information

  • Token Name: Cats are Liquid
  • Symbol: NUKO
  • Contract Address: 5HZxA385SYeydqZUpTeKj7D37T1bL9N6JA7Xde5QMP8qiSym
  • Decimals: 12

Logo

  • Logo file added to the PR
  • File Name: logo.png
  • Size: 256x256 pixels
  • File Extension: png

Metadata File

  • Metadata file added to the PR
  • File Name: metadata.json
  • File Extension: json

Token Information File

  • Token information file added to the PR
  • File Name: info.json
  • File Extension: json

Required Content in info.json:

{
  "name": "Cats are Liquid",
  "symbol": "NUKO",
  "type": "PSP22",
  "contractAddress": "5HZxA385SYeydqZUpTeKj7D37T1bL9N6JA7Xde5QMP8qiSym",
  "decimals": 12,
  "description": "$NUKO is the first cat meme token on @Aleph__Zero",
  "website": "https://www.nukotoken.org/",
  "sourceCode": "https://github.com/takeshi-nuko/PSP22-NUKO/",
  "links": [
    {
      "name": "X/Twitter",
      "url": "https://x.com/nukotoken"
    },
    {
      "name": "Telegram",
      "url": "https://t.me/nukotoken"
    },
    {
      "name": "Discord",
      "url": ""
    }
  ],
  "customTags": ["$NUKO Contract Address"],
  "warnings": [],
  "owner": "",
  "minter": ""
}

Note on Custom Tags

The customTags field in the info.json file is optional. This field can be used to include specific tags that describe unique characteristics or features of the token, such as burner wallet. Include custom tags only if they are relevant to the token’s functionality or usage.

Note on Owner and Minter

The owner and minter fields should include the addresses of the accounts that hold these capabilities within the token's smart contract. The owner is typically the account that has administrative rights over the entire contract, while the minter might be an account with the capability to issue new tokens.

Note on Warnings

Please do not fill out the warnings field in the info.json file. This field is reserved for use by our auditing team, who will add relevant warnings such as "Mintable" or "Burnable" after thoroughly reviewing the token's smart contract. This ensures that all warnings are accurate and based on a comprehensive technical assessment.

],
"customTags": ["$NUKO Contract Address"],
"warnings": [],
"owner": "5HC2nukon6y82uby553npmLVf5MnN1faXjLPqVKUhhY2EJQt",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi -- after I inspected the code it seems to me the contract does not have any owner or minter functionality. Is the assessment correct?

If yes, you can leave "owner" and "minter" empty, like:

"owner": "",
"minter": ""

Contracts with active owners/minters will have warnings displayed on ascan, so you definitely want to avoid that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had mistakenly thought that owner and minter referred to the account that deployed the project.
As you pointed out, I have left these boxes empty.
Thank you for your advice.

Copy link
Collaborator

@DamianStraszak DamianStraszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. All looks good now!

@Kodziak Kodziak merged commit 7ad77e1 into SyncraDAO:main Jul 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants