refactor(ledger): rename MerkleRootMeta.fromShred to fromFirstReceive…

…dShred This function assumes that the current shred is the first received shred. the function name should reflect that.
Syndica · Sep 26, 2024 · d6a9186 · d6a9186
1 parent 7470f67
commit d6a9186
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/ledger/insert_shred.zig b/src/ledger/insert_shred.zig
@@ -549,7 +549,7 @@ pub const ShredInserter = struct {
  self.metrics.num_inserted.inc();
  const entry = try state.merkle_root_metas.getOrPut(erasure_set_id);
  if (!entry.found_existing) {
- entry.value_ptr.* = .{ .dirty = MerkleRootMeta.fromShred(shred) };
+ entry.value_ptr.* = .{ .dirty = MerkleRootMeta.fromFirstReceivedShred(shred) };
  }
  break :blk true;
  } else |_| false;
@@ -687,7 +687,7 @@ pub const ShredInserter = struct {
  );
  const entry = try state.merkle_root_metas.getOrPut(erasure_set_id);
  if (!entry.found_existing) {
- entry.value_ptr.* = .{ .dirty = MerkleRootMeta.fromShred(shred) };
+ entry.value_ptr.* = .{ .dirty = MerkleRootMeta.fromFirstReceivedShred(shred) };
  }
  try state.just_inserted_shreds.put(shred.fields.id(), shred_union); // TODO check first?
  index_meta_working_set_entry.did_insert_occur = true;

diff --git a/src/ledger/meta.zig b/src/ledger/meta.zig
@@ -346,7 +346,7 @@ pub const MerkleRootMeta = struct {
  /// The shred type of the first received shred
  first_received_shred_type: sig.ledger.shred.ShredType,
 
- pub fn fromShred(shred: anytype) MerkleRootMeta {
+ pub fn fromFirstReceivedShred(shred: anytype) MerkleRootMeta {
  comptime std.debug.assert(
  @TypeOf(shred) == sig.ledger.shred.DataShred or
  @TypeOf(shred) == sig.ledger.shred.CodeShred,