improvement(gossip,tar): Work towards improving thread management #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNineteen
requested changes
May 28, 2024
InKryption
force-pushed
the
ink/better-threads1
branch
from
5fa4230
to
f321947
Compare
InKryption
force-pushed
the
ink/better-threads1
branch
from
fcf40c7
to
f321947
Compare
InKryption
force-pushed
the
ink/better-threads1
branch
from
f321947
to
d87361e
Compare
* [ThreadPoolTask] Rename `done` field to `avaialable`, for better clarity in the contexts it's used. * [ThreadPoolTask] Add `awaitAndAcquireFirstAvailableTask` & `blockUntilCompletion` functions, remove `queue` function, replace usages of `queue` and code which would now duplicate the aforementioned additions. * [ThreadPoolTask] Add `result` field for signalling the result of the callback. * [gossip] Make use of `ThreadPoolTask` instead of manually implementing the VerifyMessageTask Task interface details. * [gossip] Add `GOSSIP_VERIFY_PACKET_PARALLEL_TASKS` constant, and use it instead of hardcoding the tasks allocated in `verifyPackets`. * [gossip] Make `verifyPackets` and `processMessages` accept an a shared allocator, and make `run` provide a thread-safe allocator which will only be contended by a maximum of the avilable tasks plus the number of messages processed at the same time. * [tar] Panic on some invalid but possible invariants. * Constify more things that don't need to be mutable.
InKryption
force-pushed
the
ink/better-threads1
branch
from
d87361e
to
3b7b21b
Compare
* Rename `SOCKET_TIMEOUT` to `SOCKET_TIMEOUT_US`, to signify its magnitude is in microseconds. * Remove `recvMmsg` and simplify the timeout logic to simply setting it directly before the loop, and finishing the batch on the first `error.WouldBlock` when the batch isn't empty. * Use `packet_batch` as an actual arraylist instead of as a weird slice.
Re-implement the logic of `run` as a function that returns the handles which can then be joined by the caller. Most usage sites require a bit of thought with respect to the order of operations, so `GossipService.run` remains as a wrapper around the new logic. This also makes it take a `message_allocator`.
0xNineteen
requested changes
Jun 3, 2024
socket_utils comparative benchmarkI conducted many more runs than presented here, but those presented are representative of the general trends I observed, where performance is either equivalent or minimally better, excluding outliers where variance exceeded more than 100 in either (which occurred twice with the old code, and once with the new code). Side note: brief testing indicated that ReleaseFast demonstrates near identical trends. Before socket_utils changes: After socket_utils changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts work towards #119 & #120.
More details in the commits.