-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci/cd): add running gossip + benchmarks #161
Conversation
What is the downside of running it on every commit? It's nice to get feedback for each commit. |
spinning up gossip to interact with the network and send packets seems wasteful imo - feels like we would only want to run these checks before we have it reviewed (to save reviewer time) or before we merge to main (to ensure theres no bugs) - if you want it every commit, you can always run it locally? |
What resource are we wasting though? Is there an actual cost? I feel that it is useful to understand whether my recent change broke anything. While I could run the checks locally, I might forget, or I might want to use my computer for something else that it interferes with. Also, the historical record of runs provides an audit trail that can be useful to diagnose issues that might have been overlooked. |
good point - if you find it useful we can try it (fixes pushed) |
If there are no other outstanding contentions, I'd like for this to get merged. |
the CI will now run only on review request AND every review submitted (instead on every commit of a pull request) - due to the increased time it will run i didnt want to run it for long
sample run: https://github.com/Syndica/sig/actions/runs/9390446592/job/25860335747
note: decided to not include accounts-db because of the uncertainty of how long to let it run to download a snapshot and didnt want to introduce too many changes in CI in one go