Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci/cd): add running gossip + benchmarks #161

Merged
merged 17 commits into from
Jun 10, 2024
Merged

Conversation

0xNineteen
Copy link
Contributor

@0xNineteen 0xNineteen commented Jun 5, 2024

  • running gossip for N seconds and then shutting down [x]
  • run benchmarks [x]
  • unused imports check [x]

the CI will now run only on review request AND every review submitted (instead on every commit of a pull request) - due to the increased time it will run i didnt want to run it for long

sample run: https://github.com/Syndica/sig/actions/runs/9390446592/job/25860335747


note: decided to not include accounts-db because of the uncertainty of how long to let it run to download a snapshot and didnt want to introduce too many changes in CI in one go

@0xNineteen 0xNineteen marked this pull request as ready for review June 5, 2024 17:54
@0xNineteen 0xNineteen self-assigned this Jun 5, 2024
@dnut
Copy link
Contributor

dnut commented Jun 5, 2024

What is the downside of running it on every commit? It's nice to get feedback for each commit.

src/net/socket_utils.zig Outdated Show resolved Hide resolved
@0xNineteen
Copy link
Contributor Author

What is the downside of running it on every commit? It's nice to get feedback for each commit.

spinning up gossip to interact with the network and send packets seems wasteful imo - feels like we would only want to run these checks before we have it reviewed (to save reviewer time) or before we merge to main (to ensure theres no bugs) - if you want it every commit, you can always run it locally?

@dnut
Copy link
Contributor

dnut commented Jun 5, 2024

spinning up gossip to interact with the network and send packets seems wasteful

What resource are we wasting though? Is there an actual cost?

I feel that it is useful to understand whether my recent change broke anything. While I could run the checks locally, I might forget, or I might want to use my computer for something else that it interferes with. Also, the historical record of runs provides an audit trail that can be useful to diagnose issues that might have been overlooked.

@0xNineteen
Copy link
Contributor Author

0xNineteen commented Jun 6, 2024

good point - if you find it useful we can try it (fixes pushed)

@InKryption
Copy link
Contributor

If there are no other outstanding contentions, I'd like for this to get merged.

@0xNineteen 0xNineteen merged commit 8d556c3 into main Jun 10, 2024
5 checks passed
@0xNineteen 0xNineteen deleted the 19/cicd-gossip branch June 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants