refactor(accountsdb): Make the fields field optional, and validate that it's non-null before working with it
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InKryption
force-pushed
the
ink/accountsdb-refactor1
branch
6 times, most recently
from
764f103
to
5c71adb
Compare
also add better toString methods to SocketAddr
InKryption
force-pushed
the
ink/accountsdb-refactor1
branch
from
5c71adb
to
70cc91d
Compare
InKryption
changed the title
fields field a parameter insteadfields field optional, and validate that it's non-null before working with it
0xNineteen
requested changes
Jun 12, 2024
InKryption
force-pushed
the
ink/accountsdb-refactor1
branch
from
cc81452
to
e727b22
Compare
0xNineteen
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is effectively already used as a parameter, this just makes it impossible to accidentally access it as a field before it's initialized, or after it's done being useful.
Also improve the code for creating and using the disk memory allocator.