improvement(bincode,gossip): safer socket tag & bincode fix #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNineteen
requested changes
Jun 12, 2024
InKryption
force-pushed
the
ink/safer-socket-tag
branch
from
6ca9ac6
to
2e1acea
Compare
0xNineteen
previously approved these changes
Jun 12, 2024
There was a problem hiding this comment.
lgtm - but also wait for @dnut to approve bc he worked on the socket_tag prev
dnut
reviewed
Jun 13, 2024
InKryption
force-pushed
the
ink/safer-socket-tag
branch
2 times, most recently
from
b69c8ad
to
5598908
Compare
InKryption
force-pushed
the
ink/safer-socket-tag
branch
from
5598908
to
c4e1611
Compare
0xNineteen
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.