feat(net): initial go at IPv6 parsing #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathaou
changed the title
0xNineteen
approved these changes
Jun 21, 2024
mathaou
force-pushed
the
ipv6ParsingFallback
branch
from
bd2331e
to
df9eb15
Compare
|
Missed the clause on the PR that said commits must be signed. I force pushed a new one containing all the others with a proper GPG key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing this with a similar approach outlined in the IPv4 parsing would be good for performance reasons, but given that this is a fallback in the first place maybe this approach is fine for now. If this way is a non-starter, I could take another go to try and make it cleaner / faster. Tried following contributions document and the example of the rest of the code in the codebase.
Essentially, I saw a TODO and thought this might be someplace where someone without much experience with the codebase as a whole could contribute something of relative substance.