refactor: replace byte-slice Dir paths with Dir handlers #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InKryption
reviewed
Sep 29, 2024
sonicfromnewyoke
force-pushed
the
sonic/replace-byte-slice-fs
branch
from
d168192
to
6c83b66
Compare
sonicfromnewyoke
changed the title
|
all the byte-slice Dir paths are replaced by Dir handles. |
sonicfromnewyoke
force-pushed
the
sonic/replace-byte-slice-fs
branch
from
8413bfb
to
f2785a1
Compare
|
Another sporadic CI failure in the kcov test: |
0xNineteen
pushed a commit
that referenced
this pull request
Oct 9, 2024
* replace byte-slice dir in gossip dump * use sig.utils.fmt.boundedFmt instead of std.fmt.allocPrint * replace forgotten allocPrint with boundedFmt * fix conflicts with main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #183