-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(benchmarks): implement benchmarking for snapshot validation #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
force-pushed
the
Rexicon226/snapshot-bench
branch
from
September 30, 2024 19:15
17db117
to
f74f43e
Compare
Rexicon226
changed the title
implement benchmarking for snapshot validation
feat(benchmarks): implement benchmarking for snapshot validation
Sep 30, 2024
0xNineteen
requested changes
Oct 2, 2024
dnut
requested changes
Oct 3, 2024
Rexicon226
force-pushed
the
Rexicon226/snapshot-bench
branch
from
October 8, 2024 14:07
e46b192
to
696c4fd
Compare
just to have it written down: we chatted offline and decided to :
|
0xNineteen
force-pushed
the
Rexicon226/snapshot-bench
branch
2 times, most recently
from
October 15, 2024 18:44
c02f47d
to
2fa73ed
Compare
Useful for when you need to build a specific executable, but not install it.
0xNineteen
force-pushed
the
Rexicon226/snapshot-bench
branch
from
October 16, 2024 16:06
5088c80
to
8abb69f
Compare
closing to move progress to new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #283
i'd like a second opinion on 44d9939. i've found it pretty common that i want to build a specific part of sig and have it output as a binary.
Now it looks like this:
x19's notes:
example benchmark results (multiple values)
NOTE: for multiple value outputs its not human readable at all - but i think thats ok -- most of our confirmations of speed ups/slow downs shouldnt be human checked, it should be computed and the increase/decrease should be human checked (which this PR allows for you to do easily)