Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bincode): config default values #380

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat(bincode): config default values #380

merged 2 commits into from
Nov 12, 2024

Conversation

0xNineteen
Copy link
Contributor

@0xNineteen 0xNineteen commented Nov 12, 2024 •
edited
Loading

  • see doc comment on how this new field is useful
  • we also remove dead test code

@0xNineteen Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @0xNineteen and the rest of your teammates on Graphite Graphite

@0xNineteen 0xNineteen marked this pull request as ready for review November 12, 2024 21:36
InKryption
InKryption approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@InKryption InKryption left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xNineteen 0xNineteen enabled auto-merge (squash) November 12, 2024 22:40
@0xNineteen 0xNineteen merged commit 478d66e into main Nov 12, 2024
6 checks passed
@0xNineteen 0xNineteen deleted the 11-12-feat_bincode_config_default_values branch November 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InKryption InKryption InKryption approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sig
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xNineteen @InKryption