Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose data.path #80

Merged
merged 1 commit into from
Jul 31, 2024
Merged

expose data.path #80

merged 1 commit into from
Jul 31, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Jul 31, 2024 •
edited
Loading

@casperdcl casperdcl self-assigned this Jul 31, 2024
@casperdcl casperdcl added data enhancement New feature or request participant Team requests labels Jul 31, 2024
KrisThielemans
KrisThielemans reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly convert to absolute path, but maybe that's already done

@casperdcl casperdcl merged commit 730325b into main Jul 31, 2024
2 checks passed
@casperdcl casperdcl deleted the data-path branch July 31, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisThielemans KrisThielemans KrisThielemans left review comments

@paskino paskino Awaiting requested review from paskino

Assignees

@casperdcl casperdcl

Labels
data enhancement New feature or request participant Team requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_data() should return data-path as extra member
2 participants
@casperdcl @KrisThielemans