Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce number of things we build #12

Closed
KrisThielemans opened this issue Apr 23, 2017 · 7 comments
Closed

reduce number of things we build #12

KrisThielemans opened this issue Apr 23, 2017 · 7 comments
Milestone

Comments

@KrisThielemans
Copy link
Member

I think we should save ourselves some time by disabling some options (like we did for STIR)

HDF5:

  • HDF5_BUILD_EXAMPLES=OFF
  • HDF5_BUILD_HL_LIB=OFF (to be tested)
  • HDF5_BUILD_TOOLS=OFF (or are these useful?)

Gadgetron:

  • Do we need Python gadgets? If not, we don’t need boost_python.
  • Do we need Gadgetron’s MATLAB support?
@DANAJK
Copy link
Contributor

DANAJK commented Apr 24, 2017 via email

@KrisThielemans
Copy link
Member Author

boost-python is currently required after all #15

@KrisThielemans KrisThielemans added this to the v1.0 milestone May 2, 2017
@KrisThielemans
Copy link
Member Author

As mentioned in #15, we currently switch Gadgetron's Python and Matlab support off. That saves us compilation/compatibility headaches. If we want to enable this later, then we'd have to introduce CMake variable like Gadgetron_BUILD_PYTHON_GADGETS. However, then we also need to be able to tell the boost dependency that we do need boost-python (see #5), but that's probably not trivial.

KrisThielemans pushed a commit that referenced this issue Dec 20, 2017
- use CMAKE_ARGS as opposed to explicit configure command. This means
that any variables marked as superbuild will be passed through. In
particular, it means that the "original" CMAKE_GENERATOR and
CMAKE_GENERATOR_PLATFORM, which are essential on Windows, are now
used to build HDF5.
- make output of source and build consistent with other projects
- no longer build examples and tools (see #12)
@KrisThielemans
Copy link
Member Author

#64 reduced HDF5 build as suggested above. Need to introduce CMake options to enable them.

@KrisThielemans KrisThielemans modified the milestones: v1.0.0, v1.1 Dec 20, 2017
@KrisThielemans
Copy link
Member Author

@paskino, this seems a trivial thing to do, but it isn't really necessary. Therefore feel free to re-assign to v2.1

@KrisThielemans KrisThielemans modified the milestones: v2.0, v2.1 Mar 12, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.1, v2.2 Oct 6, 2019
@KrisThielemans
Copy link
Member Author

@KrisThielemans KrisThielemans modified the milestones: v3.1, v3.2 Apr 15, 2021
@KrisThielemans
Copy link
Member Author

I think this is the only thing that was pending here, but as nobody ever asked for it, I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants