Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: use CMake 3.29.6 #917

Merged
merged 4 commits into from
Jul 2, 2024
Merged

docker: use CMake 3.29.6 #917

merged 4 commits into from
Jul 2, 2024

Conversation

KrisThielemans
Copy link
Member

No description provided.

docker/build_essential-ubuntu.sh Outdated Show resolved Hide resolved
@@ -88,13 +88,15 @@ endif()
"Build Gadgetron MATLAB gadgets (not required for SIRF)" ${default_Gadgetron_BUILD_MATLAB_SUPPORT})
option(Gadgetron_USE_MKL "Instruct Gadgetron to build linking to the MKL. The user must be able to install MKL on his own." OFF)

# disable Gadgetron GPU code
set (${proj}_USE_CUDA OFF)
# TODO enable it once bug fixed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO enable it once bug fixed
# TODO enable it once bug https://github.com/gadgetron/gadgetron/issues/1231 fixed

Copy link
Contributor

@paskino paskino Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a different bug though!

34 errors detected in the compilation of "/opt/SIRF-SuperBuild/sources/Gadgetron/toolboxes/nfft/gpu/cuGriddingConvolution.cu".

https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/9756258974/job/26926216701#step:9:10749

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly it is better to refer to

@casperdcl casperdcl merged commit 34e018a into master Jul 2, 2024
1 of 8 checks passed
@casperdcl casperdcl deleted the docker_CMake_3.29.6 branch July 2, 2024 09:45
@casperdcl casperdcl mentioned this pull request Jul 2, 2024
@casperdcl casperdcl added the bug label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants