Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synergistic IO dependency fix #1194

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on May 24, 2023

  1. reorganise to cope with DISABLE_*

    The synergistic library/executables/tests have now been
    adapted for DISABLE_Gadgetron etc.
    
    The work-around in common/utilities.* has therefore been removed.
    
    a job with DISABLE_Gadgetron has been added to GHA
    
    Fixes SyneRBI#622
    KrisThielemans committed May 24, 2023
    Configuration menu
    Copy the full SHA
    dc8bbb6 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. clean-up some include statements

    - removed some superflous include statements
    - removed some predeclarations and explicitly include iutilities.h
    KrisThielemans committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f5d424a View commit details
    Browse the repository at this point in the history
  2. CMake fixes for dependencies

    - add more conditionals to see if certain things can be built
    - split csirf library into 2: csirf is now the C++ library, while
    cinterface-sirf contains the C wrappers.
    This is probably more logical, but also avoids a circular dependency on
    ImageDataWrapper (which sits in csyn, but depends on creg etc).
    ImageDataWrapper is currently not using in csirf, but only in cinterface-sirf
    (i.e. Python/MATLAB)
    - remove the option DISABLE_Synergistic when building Python/MATLAB stuff as
    disabling it would lead to linking errors (as they need ImageDataWrapper)
    KrisThielemans committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    aee8675 View commit details
    Browse the repository at this point in the history
  3. split cinterface-Reg from cReg lib and fix dependencies

    cinterface-Reg depends on STIR for TextWriter
    
    Also fix some MATLAB things related to TextWriter (untested)
    KrisThielemans committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f8b804b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2f4ca2 View commit details
    Browse the repository at this point in the history