Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Use ISMRMRD::ISMRMRD target also on Windows #840

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

KrisThielemans
Copy link
Member

We were still using the old lines, but they break compilation when both Debug and Release versions of HDF5 libraries are installed.
In any case, the new code is much simpler!

We were still using the old lines, but they break compilation when
both Debug and Release versions of HDF5 libraries are installed.
In any case, the new code is much simpler!
@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov I'm merging this as we need it now... I hope it works for you

@KrisThielemans KrisThielemans merged commit a3a70e8 into SyneRBI:master Jan 11, 2021
@evgueni-ovtchinnikov
Copy link
Contributor

evgueni-ovtchinnikov commented Jan 11, 2021

All MATLAB MR tests and demos run ok, Python and C++ ones crash, apparently on reading ISMRMRD acquisitions Dataset header.

@evgueni-ovtchinnikov evgueni-ovtchinnikov mentioned this pull request Jan 11, 2021
Merged
@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov said

C++ test of Johannes crashes at line 99 of gadgetron_data_containers.cpp, Python demos (e.g. acquisition_data.py crash at line 724.

@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov did you attempt to build both MATLAB and Python support? That will fail because of HDF5 problems I believe. You need to build a Python-only version (DISABLE_MATLAB=ON).

If this isn't it, please give more info on your set-up and how you tested this

@evgueni-ovtchinnikov
Copy link
Contributor

Rebuilt SIRF with MATLAB disabled - still the same crashes.

I remember your saying this was because of the Python's HDF5 conflicting with installed separately HDF5.

@KrisThielemans
Copy link
Member Author

yes, conflicts between libraries at compilation time and DLLs at run-time are the most likely explanation.

I'm afraid I'd need more detail for on the simple statement "rebuild SIRF with MATLAB disabled". Are you running CMake for SIRF or the SIRF-SuperBuild? Did you build in a new directory (i.e. no CMake cache)? Maybe something to discuss on Thursday?

@evgueni-ovtchinnikov
Copy link
Contributor

I have just built SIRF with SIRF-SuperBuild afresh in a new folder with MATLAB build disabled - MR scripts still crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants