Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing native/rust-qoriq dependency for qoriq #6054

Closed
hgy59 opened this issue Apr 1, 2024 · 2 comments · Fixed by #6123
Closed

missing native/rust-qoriq dependency for qoriq #6054

hgy59 opened this issue Apr 1, 2024 · 2 comments · Fixed by #6123

Comments

@hgy59
Copy link
Contributor

hgy59 commented Apr 1, 2024

After make native-clean the native/rust-qoriq dependency is not built when building rust dependent packages for qoriq.

This is related to the installation of rust in the development environment. The installation of rust must not be coupled to the installation of the toolchains.
This seems to be an issue too, when a package requires a dedicated version of rust (nightly or a specific version instead of stable)

see #6002 (comment)

@th0ma7
Copy link
Contributor

th0ma7 commented Apr 1, 2024

some randomd thoughts... why not moving it under toolchain/syno-qoriq-6-2.4-rust ... as this is a toolchain, no? Further that may allow to later do a toolchain/syno-qoriq-6.2.4-llvm (something else I got pending with missng cycles).

@hgy59 hgy59 mentioned this issue Jun 3, 2024
10 tasks
@th0ma7
Copy link
Contributor

th0ma7 commented Jun 3, 2024

Looking at what is being cached (considering there lie the issue), there are toolchain and distrib (from `.github/workflows/build.yml). Native does not seems to be cached.

Further thinking this through question is, considering toolchain got cached, would this entail that the toolchain skips its dependencies? Looking at toolchain/syno-qoriq-6.2.4/work/.depend_done cookie, absolutely - this results in the skiping of the native/rust-qoriq.

Although looking at my precedent post #6054 (comment), using toolchain/syno-qoriq-6-2.4-rust solves that as both toolchain and distrib are cached.

@hgy59 I'll create a PR with this in mind to have your thoughts on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants