Update TT-RSS to Git commit f61f2a26 and fix on DSM-6 #1976

saschpe · 2015-12-05T13:34:42Z

DSM-6.0 moved PHP into a separate package. Both /bin/php and /usr/bin/php
are minimal variants lacking the necessary MySQL PHP modules. Therefore
depend on package PHP5.6 on DSM build 7135 or later and use
/usr/local/bin/php56.

saschpe · 2015-12-05T13:35:08Z

Tested on DSM-6.0-7135. Can't hurt if someone checks on DSM-5.x

Diaoul · 2015-12-05T18:42:35Z

spk/tt-rss/src/dsm-control.sh

 PHP="/usr/bin/php"
+fi


Is it possible to make this a oneliner like USER right above?

Dr-Bean · 2015-12-06T08:32:06Z

I don't know exactly why Synology chose php56 as the binary name, but that's going to be fun when Synology decides to package PHP7.0...
Other than the comment Diaoul provided, LGTM.

saschpe · 2015-12-06T11:41:15Z

@Dr-Bean I don't know why we now need to have three php binaries across the system :-)

Dr-Bean · 2015-12-06T11:52:58Z

Probably backwards compatibility to a degree, at least during the beta. My guess is that the other binaries will disappear, or be replaced with a symlink pointing to the binary of the new package e.g. when DSM6 final is released.

One last thing I didn't notice before: could you remove PKG_FULL_NAME? That's no longer necessary.

Dr-Bean · 2015-12-06T11:53:59Z

spk/tt-rss/src/dsm-control.sh

-USER="$([ $(grep buildnumber /etc.defaults/VERSION | cut -d"\"" -f2) -ge 4418 ] && echo -n http || echo -n nobody)"
-PHP="/usr/bin/php"
+USER="$([ $(/bin/get_key_value /etc.defaults/VERSION buildnumber) -ge 4418 ] && echo -n http || echo -n nobody)"
+PHP="$([  $(/bin/get_key_value /etc.defaults/VERSION buildnumber) -ge 7135 ] && echo -n /usr/local/bin/php56 || echo -n /usr/bin/php)"


And remove the unnecessary space ;)

saschpe · 2015-12-06T12:26:17Z

Note quite sure if it's a TTRSS bug but I had to do this to get the update daemon to work:
php -r "echo time()."\n";" > lock/update_daemon.stamp
Would be great if someone could double-check.

Dr-Bean · 2015-12-10T09:23:00Z

Last question was meant for DSM6? Can't test that myself.
I assume that the new WebStation package is still running as http, so it's not a permissions issue?

saschpe · 2015-12-10T13:45:13Z

@Dr-Bean Yes, that was on DSM6. Not it's not a permission issue TT-RSS simply expects the file to be there. I'm pretty sure it's a bug since the update_daemon doesn't create it itself if missing.

So I'm unsure if we should add the above php line to the postinstall function...

Dr-Bean · 2015-12-10T14:07:00Z

That seems to be a bug or a change in behavior in TT-RSS then? The lock files are created with the current package. I only did a quick check on DSM5: I updated to the commit in this PR, and the same problem occurs: no lockfiles.
Can you check if the current TT-RSS package (with the necessary changes to the PHP version) does work on DSM6?

nickbroon · 2015-12-21T16:45:17Z

👍

Dr-Bean · 2016-01-02T09:11:25Z

@saschpe Not sure if you read my previous comment?

DSM-6.0 moved PHP into a separate package. Both /bin/php and /usr/bin/php are minimal variants lacking the necessary MySQL PHP modules. Therefore depend on package PHP5.6 on DSM build 7135 or later and use /usr/local/bin/php56.

saschpe · 2016-01-02T11:09:39Z

Seems like the issue was solved recently. The package works for me after upgrading to commit 7f4fff96. Could you please double-check?

nickbroon · 2016-01-02T21:23:54Z

Linking to tt-rss DSM6 discussion. http://forum.synology.com/enu/viewtopic.php?f=260&t=105868

Dr-Bean · 2016-01-03T10:51:56Z

Seems to work as intended on DSM5 ;) Thanks for taking care of it :)

Dr-Bean · 2016-01-05T10:23:05Z

tt-rss 20160102-10 has been published on the repository.

nickbroon · 2016-01-06T00:29:20Z

Using the new tt-rss 20160102-10 I'm seeing the following in the tt-rss logs:

E_WARNING (2) include/functions2.php:261 file_get_contents(lock/update_daemon.stamp): failed to open stream: No such file or directory [Last query: SELECT ref_id AS id FROM ttrss_user_entries WHERE owner_uid = 1 ORDER BY ref_id DESC LIMIT 1] admin 0:23

and the update daemon fails to update the feeds as a result.

Dr-Bean · 2016-01-06T07:52:40Z

Does the file exist? (/volume1/web/tt-rss/lock/update_daemon.stamp presumably)

nickbroon · 2016-01-06T08:54:23Z

Unfortunately no.

Dr-Bean · 2016-01-06T09:02:17Z

Try a fresh install maybe...it does create it here, and iirc I tested with both an upgrade and an actual clean install.
Otherwise, you can create probably it with the command @saschpe mentioned here...make sure you're located in the correct dir of course.

nickbroon · 2016-01-06T09:39:47Z

It was a fresh install on DSM6 after uninstalling the old package.
I'll try the command you mention.

Dr-Bean · 2016-01-06T09:50:48Z

Ah...DSM6. Still can't test that, so I'll leave that to @saschpe: he said it worked ;)

saschpe · 2016-01-06T17:40:26Z

Works for me, though I'll re-test by uninstalling and wiping the installation. Either way, we could add the one-liner from above into the post-install function...

saschpe · 2016-01-06T17:54:07Z

Nope, works. Just un-installed the package completely and did a fresh install.

@nickbroon Sure you installed the latest version?

reyman · 2016-01-06T18:13:29Z

I installed the version which appear today. Uninstall change nothing. Where can i find the log ?

nickbroon · 2016-01-06T18:34:42Z

@saschpe Did you uninstall the package and also manually remove the tt-rss/lock/update_daemon.stamp to make sure you have a clean starting state. (Or perhaps completely remove the tt-rss directory)

I'm definitely using 20160102-10, installed from synocommunity using Package Manager.

saschpe · 2016-01-06T21:37:03Z

@nickbroon Quick shot at fixing it: #2056

LawrenceAusten · 2016-03-27T22:54:31Z

FWIW, I did the following and everything, including updating, seems to be working fine:

rm /usr/syno/bin/php
ln -s /usr/local/bin/php56 /usr/syno/bin/php // Side effects on other packages?

change '/usr/bin/php' to '/usr/local/bin/php56' in /var/services/web/tt-rss/config.php

Restarted package via regular DSM web interface

saschpe changed the title ~~Update to git commit f61f2a26 and fix on DSM-6~~ Update TT-RSS to Git commit f61f2a26 and fix on DSM-6 Dec 5, 2015

Diaoul reviewed Dec 5, 2015
View reviewed changes

spk/tt-rss/src/dsm-control.sh

PHP="/usr/bin/php"

fi

Copy link

Member

Diaoul Dec 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make this a oneliner like USER right above?

saschpe force-pushed the ttrss-dsm6-and-update branch from 51190c4 to 2a7683f Compare December 6, 2015 11:35

Dr-Bean reviewed Dec 6, 2015
View reviewed changes

saschpe force-pushed the ttrss-dsm6-and-update branch from 2a7683f to 79631c7 Compare December 6, 2015 12:24

Dr-Bean added the status/needs-review label Jan 2, 2016

Update to git commit 7f4fff96 and fix on DSM-6

de11b90

DSM-6.0 moved PHP into a separate package. Both /bin/php and /usr/bin/php are minimal variants lacking the necessary MySQL PHP modules. Therefore depend on package PHP5.6 on DSM build 7135 or later and use /usr/local/bin/php56.

saschpe force-pushed the ttrss-dsm6-and-update branch from 79631c7 to de11b90 Compare January 2, 2016 11:08

Dr-Bean merged commit de11b90 into SynoCommunity:master Jan 3, 2016

Dr-Bean added a commit that referenced this pull request Jan 3, 2016

Merge pull request #1976 from saschpe/ttrss-dsm6-and-update

c208ca9

Dr-Bean added status/ready-to-merge and removed status/needs-review labels Jan 3, 2016

nickbroon mentioned this pull request Jan 6, 2016

Selfoss and tiny tiny rss don't launch after install #2052

Closed

saschpe deleted the ttrss-dsm6-and-update branch January 3, 2018 20:14

hgy59 removed the status/ready-to-merge label Nov 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update TT-RSS to Git commit f61f2a26 and fix on DSM-6 #1976

Update TT-RSS to Git commit f61f2a26 and fix on DSM-6 #1976

saschpe commented Dec 5, 2015

saschpe commented Dec 5, 2015

Diaoul Dec 5, 2015

Dr-Bean commented Dec 6, 2015

saschpe commented Dec 6, 2015

Dr-Bean commented Dec 6, 2015

Dr-Bean Dec 6, 2015

saschpe commented Dec 6, 2015

Dr-Bean commented Dec 10, 2015

saschpe commented Dec 10, 2015

Dr-Bean commented Dec 10, 2015

nickbroon commented Dec 21, 2015

Dr-Bean commented Jan 2, 2016

saschpe commented Jan 2, 2016

nickbroon commented Jan 2, 2016

Dr-Bean commented Jan 3, 2016

Dr-Bean commented Jan 5, 2016

nickbroon commented Jan 6, 2016

Dr-Bean commented Jan 6, 2016

nickbroon commented Jan 6, 2016

Dr-Bean commented Jan 6, 2016

nickbroon commented Jan 6, 2016

Dr-Bean commented Jan 6, 2016

saschpe commented Jan 6, 2016

saschpe commented Jan 6, 2016

reyman commented Jan 6, 2016

nickbroon commented Jan 6, 2016

saschpe commented Jan 6, 2016

LawrenceAusten commented Mar 27, 2016

Update TT-RSS to Git commit f61f2a26 and fix on DSM-6 #1976

Update TT-RSS to Git commit f61f2a26 and fix on DSM-6 #1976

Conversation

saschpe commented Dec 5, 2015

saschpe commented Dec 5, 2015

Diaoul Dec 5, 2015

Choose a reason for hiding this comment

Dr-Bean commented Dec 6, 2015

saschpe commented Dec 6, 2015

Dr-Bean commented Dec 6, 2015

Dr-Bean Dec 6, 2015

Choose a reason for hiding this comment

saschpe commented Dec 6, 2015

Dr-Bean commented Dec 10, 2015

saschpe commented Dec 10, 2015

Dr-Bean commented Dec 10, 2015

nickbroon commented Dec 21, 2015

Dr-Bean commented Jan 2, 2016

saschpe commented Jan 2, 2016

nickbroon commented Jan 2, 2016

Dr-Bean commented Jan 3, 2016

Dr-Bean commented Jan 5, 2016

nickbroon commented Jan 6, 2016

Dr-Bean commented Jan 6, 2016

nickbroon commented Jan 6, 2016

Dr-Bean commented Jan 6, 2016

nickbroon commented Jan 6, 2016

Dr-Bean commented Jan 6, 2016

saschpe commented Jan 6, 2016

saschpe commented Jan 6, 2016

reyman commented Jan 6, 2016

nickbroon commented Jan 6, 2016

saschpe commented Jan 6, 2016

LawrenceAusten commented Mar 27, 2016