Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct permissions of Sonarr/Radarr backup upon upgrade #3190

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Mar 1, 2018

@ymartin59 I think the release of just Sonarr/Radarr is creating problems. Because SABnzbd/NZBGet/Deluge are not updated they still create files as sabnzbd:users and the new Sonarr/Radarr packages are no longer part of users. I think this is the source of the problems described in #3185 . Now that you published Sonarr/Radarr, we need the downloaders to be updated ASAP.. ⏩⏩
And it also means that also other processors like Sickrage/CouchPotato also need updates right away! This whole switch needs to happen at once, we can't do it one package at a time 😨

Regarding this upgrade problem:
While I first thought that removing these files would be an option, I now see that the Sonarr/Radarr Wiki actually refer to this /tmp/ location as a valid source of recent backups. I inspected the backup and update process and these are the only folders created.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@Safihre Safihre force-pushed the sonarr-radarr-upgrade branch from 76a3cfb to 6c91a65 Compare March 1, 2018 18:43
@ymartin59
Copy link
Contributor

@Safihre The same way we decided to keep busybox in packages at least to clean up previous service user, wouldn't it be possible to enlist new service user to both sc- group and users group if available in system?

@Safihre
Copy link
Contributor Author

Safihre commented Mar 1, 2018

Sure we could, I actually did something like that for #3094.
But doesn't that sort of remove the purpose of having this whole service-user way? Could just run all packages as 1 user basically. Or am I over-generalizing?

@Safihre
Copy link
Contributor Author

Safihre commented Mar 2, 2018

@ymartin59 when are you publishing all these things like this fix and the download packages? Because in the weekend there wil be a big wave of updates since that's when users have time for it.
Otherwise we will be flooded with people complaining about permissions!

@ymartin59
Copy link
Contributor

@Safihre I do not think so, as I have unpublished/desactived radarr/nzbdrone packages from repository... Now I decided to do so as soon as an "big" issue is reported on "just published" packages. Sorry but I have a "real" life too.

@ymartin59 ymartin59 merged commit 762e3b8 into SynoCommunity:master Mar 3, 2018
@Safihre Safihre deleted the sonarr-radarr-upgrade branch March 5, 2018 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants