Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GnuPG cross-compile on rtd1296 and other ARM architectures #3449

Merged
merged 3 commits into from
Oct 21, 2018
Merged

Fix GnuPG cross-compile on rtd1296 and other ARM architectures #3449

merged 3 commits into from
Oct 21, 2018

Conversation

kukoarmas
Copy link
Contributor

Motivation: Fix GnuPG package cross-compile on ARM architectures

The Makefile in three GnuPG dependencies didn't define the correct host and target to cross-compile on several ARM architectures (and maybe non-ARM also)
The affected libraries where: gmp, libgpg-error and nettle

This PR fixes the Makefiles to allow cross-compile on (hopefully) all archs

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

ymartin59
ymartin59 requested changes Sep 16, 2018
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.
Please remove specific architecture codes by "group variables" which are: PPC_ARCHES, ARM8_ARCHES, you can find at https://github.com/SynoCommunity/spksrc/blob/master/mk/spksrc.common.mk#L35-L42

@kukoarmas
Copy link
Contributor Author

Done. Last commit removes specific arch and uses arch group variables
"make all-supported" completed successfully with these changes

@ymartin59 ymartin59 merged commit 23d652b into SynoCommunity:master Oct 21, 2018
TonyRL added a commit to TonyRL/spksrc-origin that referenced this pull request Oct 22, 2018
@TonyRL
Revert "Fix GnuPG cross-compile for ARM architectures (SynoCommunity#…
0832506 
…3449)"

This reverts commit 23d652b.
stefaang pushed a commit to stefaang/spksrc that referenced this pull request Jan 21, 2019
@kukoarmas @ymartin59
Fix GnuPG cross-compile for ARM architectures (SynoCommunity#3449)
e9c231b 
* Fixed GnuPG dependencies cross-compile for arch-rtd1296
* Fix cross-compile on other ARM archs
* Use arch group variables instead of specific arch
@hgy59
Copy link
Contributor

hgy59 commented Oct 22, 2020

@ymartin59 what was this PR for?
IMHO spksrc supports cross compilation on i686 only. With GNU_CONFIGURE = 1 the --build and --host arguments for configure are provided by the framework.
May be I missunderstand the the term cross compiling on and it is meant as cross compiling for.
I have no problem cross compiling the mentioned libraries without these --target and --host definitions.

If really --target must be defined we should use CONFIGURE_ARGS += --target=$(TC_TARGET)

@th0ma7
Copy link
Contributor

th0ma7 commented Oct 23, 2020

Hi @hgy59 and @ymartin59,

Note that with this recent PR #4010 I might have fix this issue as I have updated much of the dependency list along with gnupg ...

@kukoarmas
Copy link
Contributor Author

May be I missunderstand the the term cross compiling on and it is meant as cross compiling for.
I have no problem cross compiling the mentioned libraries without these --target and --host definitions.

Yes, I meant crosscompile "for", sorry
Maybe it's already fixed in mentioned PR because last time I did it, it worked

@hgy59 hgy59 mentioned this pull request Oct 24, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymartin59 ymartin59 ymartin59 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kukoarmas @hgy59 @th0ma7 @ymartin59