-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
borgbackup: update to 1.1.7, add borgmatic 1.2.2 #3471
borgbackup: update to 1.1.7, add borgmatic 1.2.2 #3471
Conversation
What is the Building nicely now, well done 👍 |
ruamel.yaml is required by the new version of borgmatic. Since it is a native python module, I had to add it to python3 package as a dependency: I was not able to do otherwise. |
@@ -10,7 +10,7 @@ DEPENDS += cross/setuptools cross/pip cross/wheel | |||
DEPENDS += cross/cffi cross/bcrypt cross/sqlite | |||
# Cross-compiled wheels | |||
DEPENDS += cross/lxml cross/pycrypto cross/pycurl cross/pyyaml | |||
DEPENDS += cross/msgpack-python cross/attr cross/acl cross/lz4 | |||
DEPENDS += cross/msgpack-python cross/ruamel.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing attr, acl and lz4 from Python 3?
Isn't there any way to load ruamel.yaml (typically as borgbackup package specific wheel) instead of enforcing Python 3 publish (again) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have just been added for HomeAssistant in #3396
In fact Python 3 publishing is pending because of both HomeAssistant and Borgbackup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, attr, acl and lz4 are used by no other python3 dependent packages except for borgbackup.
I managed to put those dependencies inside borkgbackup package itself.
Better check with HomeAssistant spk maintainer, because in my eyes it looks those dependencies are not used.
About ruamel.yaml, I was not able to put it inside borgbackup package (any idea?).
@@ -1,7 +1,7 @@ | |||
SPK_NAME = python | |||
SPK_SHORT_VERS = 2.7 | |||
SPK_VERS = $(SPK_SHORT_VERS).14 | |||
SPK_REV = 19 | |||
SPK_REV = 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why updating Python 2.7? borgbackup runs on Python 3, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
borgbackup depends on python3, but I had to upgrade package msgpack-python that it is used by both python and python3 packages.
Co-Authored-By: yuroller <yuroller@gmail.com>
I have tested with python3 #3529. Please review, I have planned to publish soon. |
* borgbackup: update to 1.1.7, add borgmatic 1.2.2 * [borgbackup] increase revision * update ruamel.yaml * improve installer logging for diagnostic
Motivation: Update borgbackup to 1.1.7, add borgmatic 1.2.2
Linked issues: #3418
Checklist
all-supported
completed successfullyLittle testing of borgbackup and borgmatic on DS212+