Update duplicity with oauth and Python 3 #3823

heralight · 2019-12-16T15:55:14Z

Motivation: Update duplicity to 0.8.18 to support onedrive with their new api.

~~Remarks: others backends doesn't compile anymore, synocommunity docker image is to outdated.~~

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

Remarks

The current version of duply does not work with cross/bash. As DSM >= 6.0 has /bin/bash available and this version works with duply the cross/bash dependency is removed with this PR. For DSM < 6.0 only duplycity is supported, the duply script is not.

Namlaz · 2020-01-11T15:31:50Z

Yes ! That would be great since v0.8 added multibackend support which enables the use of cost-effective cold/archive object storage solution for backups 👍

ymartin59 · 2020-04-05T12:49:09Z

Hello @heralight Thanks for your contribution. May you please update to latest duplicity version please?

ymartin59

Looks good. Still a minor improvement request to avoid copy-paste code

spk/duplicity/src/service-setup.sh

hgy59 · 2021-01-11T23:20:37Z

Yes ! That would be great since v0.8 added multibackend support which enables the use of cost-effective cold/archive object storage solution for backups 👍

Hi @Namlaz, are you still looking for this update? It would be great to get some feedback from a user of duplicity. You can download the packages as artifacts of the github build action.

Namlaz · 2021-01-13T14:44:41Z

Yes ! That would be great since v0.8 added multibackend support which enables the use of cost-effective cold/archive object storage solution for backups 👍

Hi @Namlaz, are you still looking for this update? It would be great to get some feedback from a user of duplicity. You can download the packages as artifacts of the github build action.

Hey there, definitely, thank you for the update, I'll dive back into it shortly :)

mk/spksrc.service.use_alternate_tmpdir

RomainBoulay · 2021-03-19T17:53:14Z

It would be great to get some feedback from a user of duplicity. You can download the packages as artifacts of the github build action.

@hgy59: I just did that on my DS413 (qoriq / ppc) and that worked perfectly 👍

@heralight, @ymartin59: after addressing the merge conflicts, would that PR be ready to merge?

Anyway, thanks all for working on that duplicity update! I'm quite looking forward to using the multi-backend feature, and I imagine other users are too.

hgy59 · 2021-03-20T07:13:57Z

after addressing the merge conflicts, would that PR be ready to merge?

I propose to also update python3 dependency to python38
and to rework the link creation to avoid SPK_LINKS for DSM7 compatibility.

hgy59 · 2021-03-20T13:41:38Z

Now ready to merge.
But DSM7 does not install until the loging in service-setup.sh files is reworked for dsm7 (INST_LOG is not defined and does not work anymore with dsm7).

@publicarray are you already working on a soultion to support installation logs with dsm7?

my general idea is to support something like this:

echo "Installation log from service-setup" | ${INST_LOG}

and define INST_LOG differently for dsm < 7.0 and dsm7 to use ${TEE} ... for dsm7 and >> install.log for others.

This rework of install logs is for a diffent branch and OT for this duplicity update.

hgy59 · 2021-03-20T13:44:44Z

@RomainBoulay I would kindly ask you to test again with the current package.

I already tested with x64 (on DSM7 with temp. modified service-setup.sh) and armv7.
but my tests covered only the trivial options --version and --help of duplicity and duply.

RomainBoulay · 2021-03-22T22:47:03Z

@hgy59 sorry I forgot to come back to you. This weekend I tested duplicity after your update and I can confirm my backups worked as expected 👍 From my point of view, it's good to go (DS413, DSM 6.2.3)

mk/spksrc.service.use_alternate_tmpdir.dsm7

ymartin59 · 2021-04-28T18:46:22Z

@hgy59 May you please fix/rebase branch to review PR and publish package?

- update duply to v2.3 - install duply to /bin - fix symlinks - fix dependencies and remove cross/bash - duply script is not supported on DSM < 6.0 - use service-setup.sh and remove dsm-control.sh, installer.sh

- /tmp might be too small due to the size of the installed wheels - use custom TMPDIR for installation

- update duplicity for USE_ALTERNATE_TMPDIR - update homeassistant for USE_ALTERNATE_TMPDIR

- cleanup tmpdir after installation

- create link in bin folder to avoid SPK_LINKS - use $(SYNOPKG_PKGTMP) as alternate tmpdir with dsm7 - avoid usage of /usr/local/{package-name}/

- update duply - fix default_python patch

- cffi - librsync - lxml - pycparser - use cross-cmake rules for librsync

- update requirements - update instructions on how to update requirements.txt - update changelog and list all included backends as bullet list - adjust cross dependencies - fix service-setup.sh for redesigned installer logs

* update duplicity to v0.8.19 and duply to v2.3 with python 3.8 - install duply to /bin - fix symlinks - fix dependencies and remove cross/bash - duply script is not supported on DSM < 6.0 - use service-setup.sh and remove dsm-control.sh, installer.sh * include most of the backend libraries - /tmp might be too small due to the size of the installed wheels - use custom TMPDIR for installation * add USE_ALTERNATE_TMPDIR for generic usage * incorporate code review - cleanup tmpdir after installation * update duplicity dependencies * prepare for dsm7 - create link in bin folder to avoid SPK_LINKS - use $(SYNOPKG_PKGTMP) as alternate tmpdir with dsm7 - avoid usage of /usr/local/{package-name}/ * update dependencies - cffi - librsync - lxml - pycparser - use cross-cmake rules for librsync * update duplicity to v0.8.19 - update requirements - update instructions on how to update requirements.txt - update changelog and list all included backends as bullet list - adjust cross dependencies - fix service-setup.sh for redesigned installer logs Co-authored-by: hgy59 <hpgy59@gmail.com>

ymartin59 mentioned this pull request Apr 10, 2020

Fix Python 3 wheels cross-compilation #3944

Closed

hgy59 mentioned this pull request Dec 12, 2020

Deactivate python2 #4303

Closed

10 tasks

hgy59 force-pushed the duplicity08 branch from e5a3921 to 5d3e8c8 Compare January 9, 2021 20:07

hgy59 changed the title ~~Update duplicity to 0.8.08 with oauth~~ Update duplicity with oauth Jan 10, 2021

hgy59 changed the title ~~Update duplicity with oauth~~ Update duplicity with oauth and Python 3 Jan 10, 2021

ymartin59 requested changes Jan 11, 2021

View reviewed changes

spk/duplicity/src/service-setup.sh Outdated Show resolved Hide resolved

ymartin59 requested changes Jan 17, 2021

View reviewed changes

mk/spksrc.service.use_alternate_tmpdir Show resolved Hide resolved

hgy59 force-pushed the duplicity08 branch from 3d9625a to 569c5ac Compare March 20, 2021 07:12

ymartin59 approved these changes Mar 23, 2021

View reviewed changes

publicarray reviewed Mar 24, 2021

View reviewed changes

mk/spksrc.service.use_alternate_tmpdir.dsm7 Outdated Show resolved Hide resolved

hgy59 force-pushed the duplicity08 branch from 960e860 to 98c0166 Compare April 29, 2021 15:24

heralight and others added 9 commits May 1, 2021 21:42

Update duplicity to 0.8.08 with oauth

a88e46e

update to python 3

09ae86d

- update duply to v2.3 - install duply to /bin - fix symlinks - fix dependencies and remove cross/bash - duply script is not supported on DSM < 6.0 - use service-setup.sh and remove dsm-control.sh, installer.sh

update duplicity to v0.8.18

fd732ac

include most of the backend libraries

ffd07f1

- /tmp might be too small due to the size of the installed wheels - use custom TMPDIR for installation

add USE_ALTERNATE_TMPDIR for generic usage

e0f37b2

- update duplicity for USE_ALTERNATE_TMPDIR - update homeassistant for USE_ALTERNATE_TMPDIR

incorporate code review

802d126

- cleanup tmpdir after installation

revert homeassistant changes

e41c9be

update duplicity dependencies

7d753fa

prepare for dsm7

88178fd

- create link in bin folder to avoid SPK_LINKS - use $(SYNOPKG_PKGTMP) as alternate tmpdir with dsm7 - avoid usage of /usr/local/{package-name}/

hgy59 added 5 commits May 1, 2021 21:43

update duply to v2.3.1

76f0bf8

- update duply - fix default_python patch

update duplicity to use python38

b1e552a

fix alternate TMPDIR for dsm7

7b02fdc

update dependencies

223445a

- cffi - librsync - lxml - pycparser - use cross-cmake rules for librsync

update duplicity to v0.8.19

f7e7e22

- update requirements - update instructions on how to update requirements.txt - update changelog and list all included backends as bullet list - adjust cross dependencies - fix service-setup.sh for redesigned installer logs

hgy59 force-pushed the duplicity08 branch from 9d0a4b5 to f7e7e22 Compare May 1, 2021 19:45

typos

00acc0d

hgy59 merged commit f310273 into SynoCommunity:master May 2, 2021

hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label May 3, 2021

hgy59 mentioned this pull request May 3, 2021

Meta: DSM7 package status #4524

Open

RomainBoulay mentioned this pull request May 15, 2021

duplicity 0.8.19 does not run on qoric #4634

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update duplicity with oauth and Python 3 #3823

Update duplicity with oauth and Python 3 #3823

heralight commented Dec 16, 2019 •

edited by hgy59

Loading

Namlaz commented Jan 11, 2020

ymartin59 commented Apr 5, 2020

ymartin59 left a comment

hgy59 commented Jan 11, 2021

Namlaz commented Jan 13, 2021

RomainBoulay commented Mar 19, 2021

hgy59 commented Mar 20, 2021 •

edited

Loading

hgy59 commented Mar 20, 2021

hgy59 commented Mar 20, 2021 •

edited

Loading

RomainBoulay commented Mar 22, 2021

ymartin59 commented Apr 28, 2021

Update duplicity with oauth and Python 3 #3823

Update duplicity with oauth and Python 3 #3823

Conversation

heralight commented Dec 16, 2019 • edited by hgy59 Loading

Checklist

Remarks

Namlaz commented Jan 11, 2020

ymartin59 commented Apr 5, 2020

ymartin59 left a comment

Choose a reason for hiding this comment

hgy59 commented Jan 11, 2021

Namlaz commented Jan 13, 2021

RomainBoulay commented Mar 19, 2021

hgy59 commented Mar 20, 2021 • edited Loading

hgy59 commented Mar 20, 2021

hgy59 commented Mar 20, 2021 • edited Loading

RomainBoulay commented Mar 22, 2021

ymartin59 commented Apr 28, 2021

heralight commented Dec 16, 2019 •

edited by hgy59

Loading

hgy59 commented Mar 20, 2021 •

edited

Loading

hgy59 commented Mar 20, 2021 •

edited

Loading