Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mutt and add SASL support #3923

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Update mutt and add SASL support #3923

merged 2 commits into from
Mar 22, 2020

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Mar 14, 2020 •
edited
Loading

Motivation: mutt is still actively maintained, the synocommunity package lacks SASL support
Linked issues: fix #3840, fix #3342

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Remarks

  • update mutt to version 1.13.4
  • add cross/cyrus-sasl
  • use service-setup.sh for installation (fixes mutt does not start #3342)
  • use generic symlink creation

@hgy59
Update mutt and add SASL support
ea42f8f 
- update mutt to version 1.13.4
- add cross/cyrus-sasl
- use service-setup.sh for installation
@hgy59 hgy59 added status/ready-to-merge update request to update existing package labels Mar 14, 2020
@hgy59
Copy link
Contributor Author

hgy59 commented Mar 14, 2020

@ymartin59 just found tooltips in the PR description that linked issues will be closed with the PR when prefixed with fix or fixes

@ymartin59
Copy link
Contributor

@hgy59 I was aware of this GitHub "smart behaviours", good idea to take benefits of it. We should write down many of these tricks in a "contribution FAQ" in wiki...

ymartin59
ymartin59 approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.
I still have some minor improvements proposals.

cross/cyrus-sasl/patches/001.use-host-gcc-to-fix-cross-compile-makemd5.patch Outdated Show resolved Hide resolved
cross/mutt/Makefile Outdated Show resolved Hide resolved
spk/mutt/src/service-setup.sh Outdated Show resolved Hide resolved
cross/mutt/Makefile Show resolved Hide resolved
spk/mutt/src/service-setup.sh Outdated Show resolved Hide resolved
ymartin59
ymartin59 requested changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.
I still have some minor improvements proposals.

@hgy59
Copy link
Contributor Author

hgy59 commented Mar 14, 2020

@hgy59 I was aware of this GitHub "smart behaviours", good idea to take benefits of it. We should write down many of these tricks in a "contribution FAQ" in wiki...

@ymartin59 just updated the Contributing page

ymartin59
ymartin59 requested changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an "optimization" question about mutt_install command. May you please check if it can be discarded.

cross/mutt/Makefile Show resolved Hide resolved
@ymartin59 ymartin59 merged commit 409c121 into SynoCommunity:master Mar 22, 2020
@hgy59 hgy59 deleted the update_mutt branch April 9, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymartin59 ymartin59 ymartin59 requested changes

Assignees
No one assigned
Labels
update request to update existing package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MUTT seems to not have been compiled with SASL support mutt does not start
2 participants
@hgy59 @ymartin59